Make us save favicon in incognito mode if the url is bookmarked. This

Make us save favicon in incognito mode if the url is bookmarked. This
way the bookmark bar/manager have a favicon for the page.

BUG=22670
TEST=see bug

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69345

[brettw, 2010-12-15 17:32:47]

LGTM

http://codereview.chromium.org/5753007/diff/1/chrome/browser/history/history.h
File chrome/browser/history/history.h (right):

http://codereview.chromium.org/5753007/diff/1/chrome/browser/history/history....
chrome/browser/history/history.h:218: void AddPageNoVisit(const GURL& url);
Maybe we should call this AddPageNoVisitForBookmark or something? This should
not be called if the page is not bookmarked or the URL row will be "leaked."
Normally expiration & deletion are done via the visits, so adding a
non-bookmarked URL with no visits means its orphaned. I'd like the emphasize the
valid use here (can you also say this in the comment?).

[sky, 2010-12-15 18:00:46]

I renamed the method. Don't feel you have to take another look.

  -Scott

http://codereview.chromium.org/5753007/diff/1/chrome/browser/history/history.h
File chrome/browser/history/history.h (right):

http://codereview.chromium.org/5753007/diff/1/chrome/browser/history/history....
chrome/browser/history/history.h:218: void AddPageNoVisit(const GURL& url);
On 2010/12/15 17:32:47, brettw wrote:
> Maybe we should call this AddPageNoVisitForBookmark or something? This should
> not be called if the page is not bookmarked or the URL row will be "leaked."
> Normally expiration & deletion are done via the visits, so adding a
> non-bookmarked URL with no visits means its orphaned. I'd like the emphasize
the
> valid use here (can you also say this in the comment?).

Done.

[brettw, 2010-12-15 18:02:59]

On Wed, Dec 15, 2010 at 10:00 AM,  <sky@chromium.org> wrote:
> I renamed the method. Don't feel you have to take another look.

Neither did I.

Brett