Issue 575021: Revert 38207 - bah. still can't work out why this passes fine on local machin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 575021: Revert 38207 - bah. still can't work out why this passes fine on local machin... (Closed)

Created:
10 years, 10 months ago by joth

Modified:
9 years, 7 months ago

Reviewers:
joth

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 38207 - bah. still can't work out why this passes fine on local machine & try bots. Reattempt at http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 (asserts tidy up slit out into its own change http://codereview.chromium.org/578013/show) Add tests for the geolocation network provider. Also some small tidy up a few other files. BUG=http://crbug.com/11246 TEST=unit_tests.exe gtest_filter=NetworkLocationProvider* gtest_break_on_failure Review URL: http://codereview.chromium.org/578006 TBR=joth@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38208

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -416 lines)			Patch
M	chrome/browser/geolocation/location_provider.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/geolocation/network_location_provider.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/geolocation/network_location_provider_unittest.cc	View	1 chunk	+0 lines, -392 lines	0 comments	Download
M	chrome/browser/geolocation/network_location_request.cc	View	3 chunks	+10 lines, -20 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)