Issue 578006: Re-attempt at http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 578006: Re-attempt at http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 ... (Closed)

Created:
10 years, 10 months ago by joth

Modified:
9 years, 7 months ago

Reviewers:
bulach

CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Re-attempt at http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 (asserts tidy up slit out into its own change http://codereview.chromium.org/578013/show) Add tests for the geolocation network provider. Also some small tidy up a few other files. BUG=http://crbug.com/11246 TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38207

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+416 lines, -13 lines)			Patch
M	chrome/browser/geolocation/location_provider.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/geolocation/network_location_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/browser/geolocation/network_location_provider_unittest.cc	View		1 chunk	+392 lines, -0 lines	0 comments	Download
M	chrome/browser/geolocation/network_location_request.cc	View	1 2	3 chunks	+20 lines, -10 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bulach

10 years, 10 months ago (2010-02-05 12:26:19 UTC) #2

LGTM

http://codereview.chromium.org/578006/diff/2007/1006
File chrome/browser/geolocation/network_location_request.cc (right):

http://codereview.chromium.org/578006/diff/2007/1006#newcode329
chrome/browser/geolocation/network_location_request.cc:329: // return a 200 with
location == null. Otherwise it's an error.
move this comment up

Expand Messages | Collapse Messages