Issue 575016: Now showing the browser action image (including badge) when dragging and...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 575016: Now showing the browser action image (including badge) when dragging and... (Closed)

Created:
10 years, 10 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Now showing the browser action image (including badge) when dragging and showing the badge in the overflow menu. BUG=26990 TEST=Browser actions in container/overflow should show image and badge and also while dragging back and forth. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38174

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -9 lines)			Patch
M	chrome/browser/views/browser_actions_container.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/views/browser_actions_container.cc	View		3 chunks	+28 lines, -1 line	1 comment	Download
M	chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc	View	1	2 chunks	+3 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

10 years, 10 months ago (2010-02-05 01:16:24 UTC) #2

LGTM

Now all you need to do is support animating the image and badge while you're
dragging. :)

http://codereview.chromium.org/575016/diff/3003/3005
File chrome/browser/views/browser_actions_container.cc (right):

http://codereview.chromium.org/575016/diff/3003/3005#newcode862
chrome/browser/views/browser_actions_container.cc:862: // Fill in the remaining
info.
nit: newline above comment

Expand Messages | Collapse Messages