Now showing the browser action image (including badge) when dragging and...

chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/extensions/browser_action_overflow_menu_controller.h"
 
+#include "app/gfx/canvas.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/views/browser_actions_container.h"
 #include "chrome/browser/views/extensions/browser_action_drag_data.h"
 #include "chrome/common/extensions/extension.h"
 #include "views/controls/menu/menu_item_view.h"
 
 BrowserActionOverflowMenuController::BrowserActionOverflowMenuController(
     BrowserActionsContainer* owner,
     views::MenuButton* menu_button,
     const std::vector<BrowserActionView*>& views,
     int start_index)
     : owner_(owner),
       observer_(NULL),
       menu_button_(menu_button),
       views_(&views),
       start_index_(start_index),
       for_drop_(false) {
   menu_.reset(new views::MenuItemView(this));
   menu_->set_has_icons(true);
 
-  TabContents* tab = BrowserList::GetLastActive()->GetSelectedTabContents();
-  int tab_id = tab->controller().session_id().id();
-
   size_t command_id = 0;
   for (size_t i = start_index; i < views_->size(); ++i) {
     BrowserActionView* view = (*views_)[i];
-    SkBitmap icon =
-        view->button()->extension()->browser_action()->GetIcon(tab_id);
-    if (icon.isNull())
-      icon = view->button()->default_icon();
+    scoped_ptr<gfx::Canvas> canvas(view->GetIconWithBadge());
     menu_->AppendMenuItemWithIcon(
         command_id,
         UTF8ToWide(view->button()->extension()->name()),
-        icon);
+        canvas->ExtractBitmap());
     ++command_id;
   }
 }
 
 BrowserActionOverflowMenuController::~BrowserActionOverflowMenuController() {
   if (observer_)
     observer_->NotifyMenuDeleted(this);
 }
 
 bool BrowserActionOverflowMenuController::RunMenu(gfx::NativeWindow window,
@@ skipping 136 matching lines @@
 
 BrowserActionView* BrowserActionOverflowMenuController::ViewForId(
     int id, size_t* index) {
   // The index of the view being dragged (GetCommand gives a 0-based index into
   // the overflow menu).
   size_t view_index = owner_->VisibleBrowserActions() + id;
   if (index)
     *index = view_index;
   return owner_->GetBrowserActionViewAt(view_index);
 }