Issue 5750005: Default apps promo was getting expired early if NTP open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5750005: Default apps promo was getting expired early if NTP open. (Closed)

Created:
10 years ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Bons

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Default apps promo was getting expired early if NTP open. This was a timing issue: we had a pref change observer that was triggering refresh of NTP. Inside this refresh, we checked the promo status. But setting up the pref tree of an extension during installation was also triggering this listener. BUG=64736 TEST=See bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69164

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -38 lines)			Patch
M	chrome/browser/dom_ui/app_launcher_handler.cc	View	2 chunks	+19 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/default_apps.h	View	2 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/default_apps.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/default_apps_unittest.cc	View	7 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/resources/ntp/apps.js	View	4 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages