Default apps promo was getting expired early if NTP open.

chrome/browser/extensions/default_apps.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_DEFAULT_APPS_H_
 #define CHROME_BROWSER_EXTENSIONS_DEFAULT_APPS_H_
 #pragma once
 
 #include <set>
 #include <string>
@@ skipping 32 matching lines @@
   // no apps need to be installed.
   const ExtensionIdSet* GetAppsToInstall() const;
 
   // Gets the list of default apps.
   const ExtensionIdSet* GetDefaultApps() const;
 
   // Should be called after each app is installed. Once installed_ids contains
   // all the default apps, GetAppsToInstall() will start returning NULL.
   void DidInstallApp(const ExtensionIdSet& installed_ids);
 
-  // Returns true if the apps promo should be displayed in the launcher. This
-  // starts returning true once the default apps have all been installed and
-  // stops after the promo expires.
-  bool ShouldShowPromo(const ExtensionIdSet& installed_ids);
+  // Returns true if the apps promo should be displayed in the launcher.
+  //
+  // NOTE: If the default apps have been installed, but |installed_ids| is
+  // different than GetDefaultApps(), this will permanently expire the promo.
+  bool CheckShouldShowPromo(const ExtensionIdSet& installed_ids);
 
   // Should be called after each time the promo is installed.
   void DidShowPromo();
 
   // Force the promo to be hidden.
   void SetPromoHidden();
 
  private:
-  FRIEND_TEST_ALL_PREFIXES(DefaultApps, Basics);
-  FRIEND_TEST_ALL_PREFIXES(DefaultApps, HidePromo);
-  FRIEND_TEST_ALL_PREFIXES(DefaultApps, InstallingAnAppHidesPromo);
-  FRIEND_TEST_ALL_PREFIXES(DefaultApps,
+  FRIEND_TEST_ALL_PREFIXES(ExtensionDefaultApps, Basics);
+  FRIEND_TEST_ALL_PREFIXES(ExtensionDefaultApps, HidePromo);
+  FRIEND_TEST_ALL_PREFIXES(ExtensionDefaultApps, InstallingAnAppHidesPromo);
+  FRIEND_TEST_ALL_PREFIXES(ExtensionDefaultApps,
                            ManualAppInstalledWhileInstallingDefaultApps);
 
   bool GetDefaultAppsInstalled() const;
   void SetDefaultAppsInstalled(bool val);
 
   int GetPromoCounter() const;
   void SetPromoCounter(int val);
 
   // Our permanent state is stored in this PrefService instance.
   PrefService* prefs_;
 
   // The set of default extensions. Initialized to a static list in the
   // constructor.
   ExtensionIdSet ids_;
 
   DISALLOW_COPY_AND_ASSIGN(DefaultApps);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_DEFAULT_APPS_H_