Fix memory leaks in AsynchronousPolicyProvider.

Fix memory leaks in AsynchronousPolicyProvider.

BUG=66102, 66054
TEST=valgrind on linux and mac

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68844

[danno, 2010-12-10 10:44:00]

please review

[jochen (gone - plz use gerrit), 2010-12-10 10:51:21]

LGTM

please add 66054 to the BUG line

http://codereview.chromium.org/5748002/diff/2001/chrome/browser/policy/asynch...
File chrome/browser/policy/asynchronous_policy_loader.cc (right):

http://codereview.chromium.org/5748002/diff/2001/chrome/browser/policy/asynch...
chrome/browser/policy/asynchronous_policy_loader.cc:63: void
AsynchronousPolicyLoader::UpdatePolicy(DictionaryValue* new_policy_raw) {
since this method is protected, and so classes deriving from this can use it,
please add a comment to the header that this methods takes ownership of
new_policy_raw (same for PostUpdatePolicyTask I guess)

[danno, 2010-12-10 11:05:28]

updated to TOT and running through trybots again due to stale code failures.

http://codereview.chromium.org/5748002/diff/2001/chrome/browser/policy/asynch...
File chrome/browser/policy/asynchronous_policy_loader.cc (right):

http://codereview.chromium.org/5748002/diff/2001/chrome/browser/policy/asynch...
chrome/browser/policy/asynchronous_policy_loader.cc:63: void
AsynchronousPolicyLoader::UpdatePolicy(DictionaryValue* new_policy_raw) {
On 2010/12/10 10:51:21, jochen wrote:
> since this method is protected, and so classes deriving from this can use it,
> please add a comment to the header that this methods takes ownership of
> new_policy_raw (same for PostUpdatePolicyTask I guess)

Done.

[jochen (gone - plz use gerrit), 2010-12-10 11:59:21]

still looks good :)