Fix memory leaks in AsynchronousPolicyProvider.

chrome/browser/policy/asynchronous_policy_loader.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/asynchronous_policy_loader.h"
 
 #include "base/message_loop.h"
 #include "base/task.h"
 #include "chrome/browser/browser_thread.h"
 
@@ skipping 42 matching lines @@
     DictionaryValue* new_policy = delegate_->Load();
     PostUpdatePolicyTask(new_policy);
   }
 }
 
 void AsynchronousPolicyLoader::PostUpdatePolicyTask(
     DictionaryValue* new_policy) {
   origin_loop_->PostTask(FROM_HERE, new UpdatePolicyTask(this, new_policy));
 }
 
 void AsynchronousPolicyLoader::UpdatePolicy(DictionaryValue* new_policy_raw) {

[jochen (gone - plz use gerrit), 2010/12/10 10:51:21]

since this method is protected, and so classes deriving from this can use it,
please add a comment to the header that this methods takes ownership of
new_policy_raw (same for PostUpdatePolicyTask I guess)

[danno, 2010/12/10 11:05:28]

Done.

+   scoped_ptr<DictionaryValue> new_policy(new_policy_raw);
   DCHECK(policy_.get());
-  if (!policy_->Equals(new_policy_raw)) {
-    policy_.reset(new_policy_raw);
+  if (!policy_->Equals(new_policy.get())) {
+    policy_.reset(new_policy.release());
     // TODO(danno): Change the notification between the provider and the
     // PrefStore into a notification mechanism, removing the need for the
     // WeakPtr for the provider.
     if (provider_)
       provider_->NotifyStoreOfPolicyChange();
   }
 }
 
 }  // namespace policy