Issue 5745005: Provide baseline GC version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5745005: Provide baseline GC version. (Closed)

Created:
10 years ago by Vyacheslav Egorov (Chromium)

Modified:
10 years ago

Reviewers:
Erik Corry, Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Provide baseline GC version. - No code flushing; - No compaction; - No write-barriers (whole old space is scanned for pointers); The idea is to build all GC experiments on top of this baseline version.

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+131 lines, -9 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/globals.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap.h	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	src/heap.cc	View	7 chunks	+18 lines, -1 line	0 comments	Download
M	src/heap-inl.h	View	4 chunks	+12 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	5 chunks	+9 lines, -0 lines	1 comment	Download
M	src/ia32/ic-ia32.cc	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	6 chunks	+6 lines, -0 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	src/mark-compact.h	View	4 chunks	+4 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	11 chunks	+20 lines, -4 lines	0 comments	Download
M	src/objects.h	View	4 chunks	+4 lines, -0 lines	0 comments	Download
M	src/objects-inl.h	View	4 chunks	+6 lines, -2 lines	0 comments	Download
M	src/spaces.h	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	src/spaces.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/spaces-inl.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	test/cctest/test-mark-compact.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-spaces.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

10 years ago (2010-12-13 13:38:01 UTC) #2

Drive by comment.

http://codereview.chromium.org/5745005/diff/1/src/ia32/codegen-ia32.cc
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/5745005/diff/1/src/ia32/codegen-ia32.cc#newcod...
src/ia32/codegen-ia32.cc:9668: Immediate(delta_to_patch_site));
This can cause short encoding for the test instruction and
StoreIC::PatchInlinedStore might fail.

Expand Messages | Collapse Messages