Chromium Code Reviews

Issue 5743002: Add a separate cookie for the start of a PPAPI test to help reduce test... (Closed)

Created:
10 years ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add a separate cookie for the start of a PPAPI test to help reduce test flakyness. This also ups the timeout time for actually running the test. We don't know what the tests do (some of the file ones do a lot of I/O), so the short timeout is somewhat dangerous. We have not historically had many problems with hanging tests other than problems with startup (which has a shorter timeout), so I think the longer test timeout is unlikely to cause problems. TEST=this is BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68819

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Stats (+22 lines, -2 lines)
M chrome/test/ui/ppapi_uitest.cc View 2 chunks +19 lines, -1 line 0 comments
M ppapi/tests/testing_instance.cc View 2 chunks +3 lines, -1 line 0 comments

Messages

Total messages: 5 (0 generated)
brettw
10 years ago (2010-12-09 21:29:03 UTC) #1
viettrungluu
http://codereview.chromium.org/5743002/diff/1/chrome/test/ui/ppapi_uitest.cc File chrome/test/ui/ppapi_uitest.cc (right): http://codereview.chromium.org/5743002/diff/1/chrome/test/ui/ppapi_uitest.cc#newcode93 chrome/test/ui/ppapi_uitest.cc:93: // making sure we're making forward progress. Uhm, this ...
10 years ago (2010-12-09 23:20:21 UTC) #2
brettw
Whoops.
10 years ago (2010-12-09 23:50:56 UTC) #3
brettw
(new snap up)
10 years ago (2010-12-09 23:51:06 UTC) #4
viettrungluu
10 years ago (2010-12-09 23:54:45 UTC) #5
lgtm

Powered by Google App Engine