Add a separate cookie for the start of a PPAPI test to help reduce test...

chrome/test/ui/ppapi_uitest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/path_service.h"
+#include "base/test/test_timeouts.h"
 #include "build/build_config.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/automation/tab_proxy.h"
 #include "chrome/test/ui/ui_test.h"
 #include "net/base/net_util.h"
 #include "net/test/test_server.h"
 #include "webkit/glue/plugins/plugin_switches.h"
 
 namespace {
 
@@ skipping 60 matching lines @@
         FilePath(FILE_PATH_LITERAL("ppapi/tests")));
     ASSERT_TRUE(test_server.Start());
     RunTestURL(test_server.GetURL("files/test_case.html?" + test_case));
   }
 
  private:
   void RunTestURL(const GURL& test_url) {
     scoped_refptr<TabProxy> tab(GetActiveTab());
     ASSERT_TRUE(tab.get());
     ASSERT_TRUE(tab->NavigateToURL(test_url));
+
+    // First wait for the "starting" signal. This cookie is set at the start
+    // of every test. Waiting for this separately allows us to avoid a single
+    // long timeout. Instead, we can have two timeouts which allow startup +
+    // test execution time to take a while on a loaded computer, while also
+    // making sure we're making forward progress.

[viettrungluu, 2010/12/09 23:20:22]

Uhm, this is all commented out?

+    /*
+    std::string startup_cookie =
+        WaitUntilCookieNonEmpty(tab.get(), test_url,
+            "STARTUP_COOKIE", action_max_timeout_ms());
+
+    // If this fails, the plugin couldn't be loaded in the given amount of
+    // time. This may mean the plugin was not found or possibly the system
+    // can't load it due to missing symbols, etc.
+    ASSERT_STREQ("STARTED", startup_cookie.c_str())
+        << "Plugin couldn't be loaded. Make sure the PPAPI test plugin is "
+        << "built, in the right place, and doesn't have any missing symbols.";
+        */
+
     std::string escaped_value =
         WaitUntilCookieNonEmpty(tab.get(), test_url,
-            "COMPLETION_COOKIE", action_max_timeout_ms());
+            "COMPLETION_COOKIE", TestTimeouts::large_test_timeout_ms());
     EXPECT_STREQ("PASS", escaped_value.c_str());
   }
 };
 
 TEST_F(PPAPITest, FAILS_Instance) {
   RunTest("Instance");
 }
 
 TEST_F(PPAPITest, Graphics2D) {
   RunTest("Graphics2D");
@@ skipping 43 matching lines @@
 
 // TODO(dumi): figure out why this test is flaky / crashing.
 TEST_F(PPAPITest, DISABLED_FileRef) {
   RunTestViaHTTP("FileRef");
 }
 
 // http://crbug.com/63239
 TEST_F(PPAPITest, DISABLED_DirectoryReader) {
   RunTestViaHTTP("DirectoryReader");
 }