Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: chrome/browser/extensions/extension_management_browsertest.cc

Issue 5742008: Clean up threading model of external extension providers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management_browsertest.cc
diff --git a/chrome/browser/extensions/extension_management_browsertest.cc b/chrome/browser/extensions/extension_management_browsertest.cc
index a1eb2f66d8ed0e09d7414f5d308c98830860d919..c2ded2f191692499972c4d0651931320aaef6dc0 100644
--- a/chrome/browser/extensions/extension_management_browsertest.cc
+++ b/chrome/browser/extensions/extension_management_browsertest.cc
@@ -365,6 +365,14 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ExternalPolicyRefresh) {
EXPECT_EQ(Extension::EXTERNAL_POLICY_DOWNLOAD,
extensions->at(size_before)->location());
- // Check that emptying the list doesn't cause any trouble.
- prefs->ClearPref(prefs::kExtensionInstallForceList);
+ // Check that emptying the list triggers uninstall.
+ {
+ ScopedPrefUpdate pref_update(prefs, prefs::kExtensionInstallForceList);
+ prefs->ClearPref(prefs::kExtensionInstallForceList);
+ }
+ EXPECT_EQ(size_before, extensions->size());
+ ExtensionList::const_iterator i;
+ for (i = extensions->begin(); i != extensions->end(); ++i) {
jochen (gone - plz use gerrit) 2011/01/04 12:38:01 no { }
gfeher 2011/01/04 23:37:09 Done.
+ EXPECT_FALSE("ogjcoiohnmldgjemafoockdghcjciccf" == (*i)->id());
jochen (gone - plz use gerrit) 2011/01/04 12:38:01 EXPECT_NE
Sam Kerner (Chrome) 2011/01/04 14:06:00 Use kExtensionId instead of the string constant.
gfeher 2011/01/04 23:37:09 Done.
gfeher 2011/01/04 23:37:09 Done.
+ }
}

Powered by Google App Engine
This is Rietveld 408576698