Clean up threading model of external extension providers

chrome/browser/extensions/extension_management_browsertest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/ref_counted.h"
 #include "chrome/browser/extensions/autoupdate_interceptor.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
@@ skipping 347 matching lines @@
 
   // Check if the extension got installed.
   ASSERT_TRUE(WaitForExtensionInstall());
   const ExtensionList* extensions = service->extensions();
   ASSERT_EQ(size_before + 1, extensions->size());
   ASSERT_EQ(kExtensionId, extensions->at(size_before)->id());
   EXPECT_EQ("2.0", extensions->at(size_before)->VersionString());
   EXPECT_EQ(Extension::EXTERNAL_POLICY_DOWNLOAD,
             extensions->at(size_before)->location());
 
-  // Check that emptying the list doesn't cause any trouble.
-  prefs->ClearPref(prefs::kExtensionInstallForceList);
+  // Check that emptying the list triggers uninstall.
+  {
+    ScopedPrefUpdate pref_update(prefs, prefs::kExtensionInstallForceList);
+    prefs->ClearPref(prefs::kExtensionInstallForceList);
+  }
+  EXPECT_EQ(size_before, extensions->size());
+  ExtensionList::const_iterator i;
+  for (i = extensions->begin(); i != extensions->end(); ++i) {

[jochen (gone - plz use gerrit), 2011/01/04 12:38:01]

no { }

[gfeher, 2011/01/04 23:37:09]

Done.

+    EXPECT_FALSE("ogjcoiohnmldgjemafoockdghcjciccf" == (*i)->id());

[jochen (gone - plz use gerrit), 2011/01/04 12:38:01]

EXPECT_NE

[Sam Kerner (Chrome), 2011/01/04 14:06:00]

Use kExtensionId instead of the string constant.  

[gfeher, 2011/01/04 23:37:09]

Done.

[gfeher, 2011/01/04 23:37:09]

Done.

+  }
 }