Issue 574009: Fixed random style violations.

Issue 574009: Fixed random style violations. (Closed)

Created:
10 years, 10 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixed random style violations. Committed: http://code.google.com/p/v8/source/detail?r=3801

Patch Set 2 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+168 lines, -174 lines)			Patch
M	src/arm/assembler-arm.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/arm/assembler-arm.cc	View	1	47 chunks	+79 lines, -77 lines	0 comments	Download
M	src/arm/assembler-thumb2.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1	3 chunks	+9 lines, -13 lines	0 comments	Download
M	src/ia32/assembler-ia32.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	1	20 chunks	+29 lines, -30 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/assembler-x64.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1	30 chunks	+40 lines, -43 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/574009/diff/1/2 File src/ia32/assembler-ia32.cc (right): http://codereview.chromium.org/574009/diff/1/2#newcode349 src/ia32/assembler-ia32.cc:349: ASSERT(pc_ <= reloc_info_writer.pos()); // no overlap Missed one! ...

10 years, 10 months ago (2010-02-04 20:47:13 UTC) #2

Søren Thygesen Gjesse

10 years, 10 months ago (2010-02-04 21:28:26 UTC) #3

There are definitely more comments to fix. I only grepped for the ones starting
a line.

http://codereview.chromium.org/574009/diff/1/2
File src/ia32/assembler-ia32.cc (right):

http://codereview.chromium.org/574009/diff/1/2#newcode349
src/ia32/assembler-ia32.cc:349: ASSERT(pc_ <= reloc_info_writer.pos());  // no
overlap
On 2010/02/04 20:47:13, Erik Corry wrote:
> Missed one!

Done.

http://codereview.chromium.org/574009/diff/1/2#newcode767
src/ia32/assembler-ia32.cc:767: if (src.is(eax) || dst.is(eax)) {  //
Single-byte encoding
On 2010/02/04 20:47:13, Erik Corry wrote:
> And here.

Done.

http://codereview.chromium.org/574009/diff/1/5
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/574009/diff/1/5#newcode342
src/x64/assembler-x64.cc:342: ASSERT(pc_ <= reloc_info_writer.pos());  // no
overlap
On 2010/02/04 20:47:13, Erik Corry wrote:
> And here.

Done.

http://codereview.chromium.org/574009/diff/1/5#newcode392
src/x64/assembler-x64.cc:392: ASSERT(buffer_overflow());  // should not call
this otherwise
On 2010/02/04 20:47:13, Erik Corry wrote:
> Superfluous comment is wrongly formatted.

Removed (and in assembler-ia32.cc as well).

http://codereview.chromium.org/574009/diff/1/5#newcode421
src/x64/assembler-x64.cc:421: //Ccopy the data.
On 2010/02/04 20:47:13, Erik Corry wrote:
> Oops.

Done.

Expand Messages | Collapse Messages