Resurrect Petr's 64-bit dynamic code modification CL:...

src/trusted/validator_x86/nccopycode.h

Index: src/trusted/validator_x86/nccopycode.h
===================================================================
--- src/trusted/validator_x86/nccopycode.h	(revision 3931)
+++ src/trusted/validator_x86/nccopycode.h	(working copy)
@@ -9,9 +9,17 @@
 
 #include "native_client/src/trusted/validator_x86/types_memory_model.h"
 
+#if NACL_TARGET_SUBARCH == 32
 /* copies code from src to dest in a thread safe way, returns 0 on success */

[bsy, 2011/01/05 00:56:22]

what do non-zero values mean?

 int NCCopyCode(uint8_t *dst, uint8_t *src, NaClPcAddress vbase,
                 size_t sz, int bundle_size);
 
+#elif NACL_TARGET_SUBARCH == 64
+int NaClCopyCodeIter(uint8_t *dst, uint8_t *src,

[bsy, 2011/01/05 00:56:22]

plz add comment on return value convention.  this seems a little weird, in that
0 is success and 1 is failure.  in the rest of the TCB, we have bool style
functions and syscall style functions, where the former style used 0/1 for
failure/success, and the latter style used negated errno values for (a range of)
failures and others indicate success.

consider switching to one of these, probably the bool style.

[elijahtaylor (use chromium), 2011/01/05 21:08:48]

Changed to the bool style, would like someone to look again to make sure I
didn't mess anything up anywhere.

+                     NaClPcAddress vbase, size_t size);
+#else
+#error "Unknown Platform"
+#endif
+
 #endif  /* NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_COPYCODE_H_ */