src/trusted/validator_x86/nccopycode.h - Issue 5738003: Resurrect Petr's 64-bit dynamic code modification CL:...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/nccopycode.h

Issue 5738003: Resurrect Petr's 64-bit dynamic code modification CL:... (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/

Patch Set: added test for double-break condition Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« src/trusted/service_runtime/sel_validate_image.c ('K') | « src/trusted/service_runtime/sel_validate_image.c ('k') | src/trusted/validator_x86/nccopycode.c » ('j') | tests/dynamic_code_loading/dynamic_modify_test.c » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright 2010 The Native Client Authors. All rights reserved.	2 * Copyright 2010 The Native Client Authors. All rights reserved.

3 * Use of this source code is governed by a BSD-style license that can	3 * Use of this source code is governed by a BSD-style license that can

4 * be found in the LICENSE file.	4 * be found in the LICENSE file.

5 */	5 */

6	6

7 #ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCCOPYCODE_H_	7 #ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCCOPYCODE_H_

8 #define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCCOPYCODE_H_	8 #define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCCOPYCODE_H_

9	9

10 #include "native_client/src/trusted/validator_x86/types_memory_model.h"	10 #include "native_client/src/trusted/validator_x86/types_memory_model.h"

11	11

	12 #if NACL_TARGET_SUBARCH == 32

12 /* copies code from src to dest in a thread safe way, returns 0 on success */	13 /* copies code from src to dest in a thread safe way, returns 0 on success */
	bsy 2011/01/05 00:56:22 what do non-zero values mean? what do non-zero values mean?
13 int NCCopyCode(uint8_t dst, uint8_t src, NaClPcAddress vbase,	14 int NCCopyCode(uint8_t dst, uint8_t src, NaClPcAddress vbase,

14 size_t sz, int bundle_size);	15 size_t sz, int bundle_size);

15	16

	17 #elif NACL_TARGET_SUBARCH == 64

	18 int NaClCopyCodeIter(uint8_t dst, uint8_t src,
	bsy 2011/01/05 00:56:22 plz add comment on return value convention. this plz add comment on return value convention. this seems a little weird, in that 0 is success and 1 is failure. in the rest of the TCB, we have bool style functions and syscall style functions, where the former style used 0/1 for failure/success, and the latter style used negated errno values for (a range of) failures and others indicate success. consider switching to one of these, probably the bool style. elijahtaylor (use chromium) 2011/01/05 21:08:48 Changed to the bool style, would like someone to l Show quoted text On 2011/01/05 00:56:22, bsy wrote: > plz add comment on return value convention. this seems a little weird, in that > 0 is success and 1 is failure. in the rest of the TCB, we have bool style > functions and syscall style functions, where the former style used 0/1 for > failure/success, and the latter style used negated errno values for (a range of) > failures and others indicate success. > > consider switching to one of these, probably the bool style. Changed to the bool style, would like someone to look again to make sure I didn't mess anything up anywhere.
	19 NaClPcAddress vbase, size_t size);

	20 #else

	21 #error "Unknown Platform"

	22 #endif

	23

16 #endif /* NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_COPYCODE_H_ */	24 #endif /* NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_COPYCODE_H_ */

17	25

OLD	NEW