Issue 5729005: webkit: use string16 in webkit_glue.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5729005: webkit: use string16 in webkit_glue.h (Closed)

Created:
10 years ago by Evan Martin

Modified:
3 years, 10 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

webkit: use string16 in webkit_glue.h And a few places that it touches. BUG=23581 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69147

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -42 lines)			Patch
M	webkit/glue/webkit_glue.h	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	webkit/glue/webkit_glue.cc	View	5 chunks	+25 lines, -22 lines	1 comment	Download
M	webkit/tools/test_shell/layout_test_controller.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	3 chunks	+9 lines, -7 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

10 years ago (2010-12-14 01:22:18 UTC) #3

LGTM with nit fixed (and green-ish tries).

http://codereview.chromium.org/5729005/diff/1/webkit/glue/webkit_glue.cc
File webkit/glue/webkit_glue.cc (right):

http://codereview.chromium.org/5729005/diff/1/webkit/glue/webkit_glue.cc#newc...
webkit/glue/webkit_glue.cc:190: int indent, bool is_current) {
Nit: realign indentation.

Expand Messages | Collapse Messages