Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: webkit/tools/test_shell/test_shell.cc

Issue 5729005: webkit: use string16 in webkit_glue.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/tools/test_shell/test_shell.cc
diff --git a/webkit/tools/test_shell/test_shell.cc b/webkit/tools/test_shell/test_shell.cc
index aaa6d37b3222b7215843e3bfea1db5518bf4b15b..fcd177325c826d625c60e44dc90a11821197aacf 100644
--- a/webkit/tools/test_shell/test_shell.cc
+++ b/webkit/tools/test_shell/test_shell.cc
@@ -272,14 +272,14 @@ void TestShell::Dump(TestShell* shell) {
bool recursive = shell->layout_test_controller_->
ShouldDumpChildFrameScrollPositions();
- printf("%s", WideToUTF8(
+ printf("%s", UTF16ToUTF8(
webkit_glue::DumpFrameScrollPosition(frame, recursive)).c_str());
}
if (shell->layout_test_controller_->ShouldDumpBackForwardList()) {
- std::wstring bfDump;
+ string16 bfDump;
DumpAllBackForwardLists(&bfDump);
- printf("%s", WideToUTF8(bfDump).c_str());
+ printf("%s", UTF16ToUTF8(bfDump).c_str());
}
}
@@ -563,7 +563,7 @@ void TestShell::BindJSObjectsToWindow(WebFrame* frame) {
}
}
-void TestShell::DumpBackForwardEntry(int index, std::wstring* result) {
+void TestShell::DumpBackForwardEntry(int index, string16* result) {
int current_index = navigation_controller_->GetLastCommittedEntryIndex();
std::string content_state =
@@ -577,13 +577,15 @@ void TestShell::DumpBackForwardEntry(int index, std::wstring* result) {
webkit_glue::DumpHistoryState(content_state, 8, index == current_index));
}
-void TestShell::DumpBackForwardList(std::wstring* result) {
- result->append(L"\n============== Back Forward List ==============\n");
+void TestShell::DumpBackForwardList(string16* result) {
+ result->append(ASCIIToUTF16(
+ "\n============== Back Forward List ==============\n"));
for (int i = 0; i < navigation_controller_->GetEntryCount(); ++i)
DumpBackForwardEntry(i, result);
- result->append(L"===============================================\n");
+ result->append(ASCIIToUTF16(
+ "===============================================\n"));
}
void TestShell::CallJSGC() {

Powered by Google App Engine
This is Rietveld 408576698