Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 5729003: Mac: Fix stuck hover state in bookmark button... (Closed)

Created:
10 years ago by Leib
Modified:
9 years, 7 months ago
Reviewers:
mrossetti, Nico, sail
CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Mac: Fix stuck hover state in bookmark button Bookmark buttons would get stuck with a hover state if they were obscured while the mouse was inside the button. The problem was that the hover state only tracked the mouse entered and exited events. Unfortunately if the button is obscured because it has been removed from the window then a mouse exited event is not sent. Fix was to also update the hover state in the -[NSCell resetCursorRect:inView:] event. This change also improves the mouse tracking code by checking if the mouse is already in over the button. BUG=27073 TEST=Changed tabs with the mouse over a bookmark button. Verified that the hover effect was no longer there after closing the new tab. Did a similar test by entering full screen. Verified that the hover effect was no longer there.

Patch Set 1 #

Total comments: 10

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -10 lines) Patch
M chrome/browser/ui/cocoa/gradient_button_cell.mm View 1 3 chunks +42 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Leib
10 years ago (2010-12-10 04:54:46 UTC) #1
mrossetti
LGTM after fixing style issues. http://codereview.chromium.org/5729003/diff/1/chrome/browser/ui/cocoa/gradient_button_cell.mm File chrome/browser/ui/cocoa/gradient_button_cell.mm (right): http://codereview.chromium.org/5729003/diff/1/chrome/browser/ui/cocoa/gradient_button_cell.mm#newcode716 chrome/browser/ui/cocoa/gradient_button_cell.mm:716: { Move brace up ...
10 years ago (2010-12-10 18:12:49 UTC) #2
Leib
Addressed review comments. http://codereview.chromium.org/5729003/diff/1/chrome/browser/ui/cocoa/gradient_button_cell.mm File chrome/browser/ui/cocoa/gradient_button_cell.mm (right): http://codereview.chromium.org/5729003/diff/1/chrome/browser/ui/cocoa/gradient_button_cell.mm#newcode716 chrome/browser/ui/cocoa/gradient_button_cell.mm:716: { On 2010/12/10 18:12:49, mrossetti wrote: ...
10 years ago (2010-12-13 17:32:00 UTC) #3
Leib
Submitting this change. Thanks for the review.
10 years ago (2010-12-13 17:37:09 UTC) #4
sail
10 years ago (2010-12-13 23:32:45 UTC) #5
Submitted as change 69068.

Powered by Google App Engine
This is Rietveld 408576698