Issue 5712005: Merge 68891 - [Sync] Fixed sync crash regression in ServerNotifierThread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5712005: Merge 68891 - [Sync] Fixed sync crash regression in ServerNotifierThread (Closed)

Created:
10 years ago by akalin

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, Raghu Simha, idana, Paweł Hajdan Jr., tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/branches/597/src

Visibility:
Public.

Description

Merge 68891 - [Sync] Fixed sync crash regression in ServerNotifierThread Added unit tests for ServerNotifierThread. Put DISABLE_RUNNABLE_METHOD_REFCOUNT() call for MediatorThreadImpl in the right place. BUG=57898 TEST=New unittests Review URL: http://codereview.chromium.org/5722002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68891 0039d316-1c4b-4281-b951-d872f2087c98 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68937

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+159 lines, -13 lines)			Patch
M	chrome/browser/sync/notifier/server_notifier_thread.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
A	chrome/browser/sync/notifier/server_notifier_thread_unittest.cc	View	1 chunk	+148 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	jingle/notifier/base/fake_base_task.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	jingle/notifier/base/fake_base_task.cc	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	jingle/notifier/listener/mediator_thread_impl.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	jingle/notifier/listener/mediator_thread_impl.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download