Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 5722002: [Sync] Fixed sync crash regression in ServerNotifierThread (Closed)

Created:
10 years ago by akalin
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, Raghu Simha, idana, Paweł Hajdan Jr., tim (not reviewing)
Visibility:
Public.

Description

[Sync] Fixed sync crash regression in ServerNotifierThread Added unit tests for ServerNotifierThread. Put DISABLE_RUNNABLE_METHOD_REFCOUNT() call for MediatorThreadImpl in the right place. BUG=57898 TEST=New unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -13 lines) Patch
M chrome/browser/sync/notifier/server_notifier_thread.cc View 1 chunk +3 lines, -1 line 0 comments Download
A chrome/browser/sync/notifier/server_notifier_thread_unittest.cc View 1 chunk +148 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M jingle/notifier/base/fake_base_task.h View 2 chunks +2 lines, -3 lines 0 comments Download
M jingle/notifier/base/fake_base_task.cc View 2 chunks +1 line, -5 lines 0 comments Download
M jingle/notifier/listener/mediator_thread_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M jingle/notifier/listener/mediator_thread_impl.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
akalin
+nicholas for review
10 years ago (2010-12-10 03:43:35 UTC) #1
akalin
ping! On 2010/12/10 03:43:35, akalin wrote: > +nicholas for review
10 years ago (2010-12-10 21:07:27 UTC) #2
Nicolas Zea
10 years ago (2010-12-10 21:58:08 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698