Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 5712003: webkit: use string16 in ContextMenuParams (Closed)

Created:
10 years ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, brettw-cc_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

webkit: use string16 in ContextMenuParams BUG=23581 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69074

Patch Set 1 #

Patch Set 2 : ok #

Patch Set 3 : works #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_menu_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_menu_manager_unittest.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/context_menu.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
trung, tony is gone so you are my only hope. this change is smaller than ...
10 years ago (2010-12-13 23:35:59 UTC) #1
viettrungluu
10 years ago (2010-12-13 23:38:40 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698