Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: webkit/glue/context_menu.h

Issue 5712003: webkit: use string16 in ContextMenuParams (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: works Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/tab_contents/tab_contents_view_gtk.cc ('k') | webkit/glue/context_menu.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_GLUE_CONTEXT_MENU_H_ 5 #ifndef WEBKIT_GLUE_CONTEXT_MENU_H_
6 #define WEBKIT_GLUE_CONTEXT_MENU_H_ 6 #define WEBKIT_GLUE_CONTEXT_MENU_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/utf_string_conversions.h" 11 #include "base/string16.h"
12 #include "googleurl/src/gurl.h" 12 #include "googleurl/src/gurl.h"
13 #include "webkit/glue/webmenuitem.h" 13 #include "webkit/glue/webmenuitem.h"
14 14
15 #include "third_party/WebKit/WebKit/chromium/public/WebContextMenuData.h" 15 #include "third_party/WebKit/WebKit/chromium/public/WebContextMenuData.h"
16 16
17 // Parameters structure for ViewHostMsg_ContextMenu. 17 // Parameters structure for ViewHostMsg_ContextMenu.
18 // FIXME(beng): This would be more useful in the future and more efficient 18 // FIXME(beng): This would be more useful in the future and more efficient
19 // if the parameters here weren't so literally mapped to what 19 // if the parameters here weren't so literally mapped to what
20 // they contain for the ContextMenu task. It might be better 20 // they contain for the ContextMenu task. It might be better
21 // to make the string fields more generic so that this object 21 // to make the string fields more generic so that this object
(...skipping 28 matching lines...) Expand all
50 GURL page_url; 50 GURL page_url;
51 51
52 // This is the URL of the subframe that the context menu was invoked on. 52 // This is the URL of the subframe that the context menu was invoked on.
53 GURL frame_url; 53 GURL frame_url;
54 54
55 // These are the parameters for the media element that the context menu 55 // These are the parameters for the media element that the context menu
56 // was invoked on. 56 // was invoked on.
57 int media_flags; 57 int media_flags;
58 58
59 // This is the text of the selection that the context menu was invoked on. 59 // This is the text of the selection that the context menu was invoked on.
60 std::wstring selection_text; 60 string16 selection_text;
61 61
62 // The misspelled word under the cursor, if any. Used to generate the 62 // The misspelled word under the cursor, if any. Used to generate the
63 // |dictionary_suggestions| list. 63 // |dictionary_suggestions| list.
64 string16 misspelled_word; 64 string16 misspelled_word;
65 65
66 // Suggested replacements for a misspelled word under the cursor. 66 // Suggested replacements for a misspelled word under the cursor.
67 // This vector gets populated in the render process host 67 // This vector gets populated in the render process host
68 // by intercepting ViewHostMsg_ContextMenu in ResourceMessageFilter 68 // by intercepting ViewHostMsg_ContextMenu in ResourceMessageFilter
69 // and populating dictionary_suggestions if the type is EDITABLE 69 // and populating dictionary_suggestions if the type is EDITABLE
70 // and the misspelled_word is not empty. 70 // and the misspelled_word is not empty.
(...skipping 24 matching lines...) Expand all
95 std::string frame_charset; 95 std::string frame_charset;
96 96
97 std::vector<WebMenuItem> custom_items; 97 std::vector<WebMenuItem> custom_items;
98 98
99 ContextMenuParams(); 99 ContextMenuParams();
100 ContextMenuParams(const WebKit::WebContextMenuData& data); 100 ContextMenuParams(const WebKit::WebContextMenuData& data);
101 ~ContextMenuParams(); 101 ~ContextMenuParams();
102 }; 102 };
103 103
104 #endif // WEBKIT_GLUE_CONTEXT_MENU_H_ 104 #endif // WEBKIT_GLUE_CONTEXT_MENU_H_
OLDNEW
« no previous file with comments | « chrome/browser/tab_contents/tab_contents_view_gtk.cc ('k') | webkit/glue/context_menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698