Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5711001: Add a new GetInstance() method for remaining files with singleton classes under chrome/browser. (Closed)

Created:
10 years ago by Satish
Modified:
9 years, 7 months ago
Reviewers:
joth
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, James Hawkins, davemoore+watch_chromium.org, dhollowa
Visibility:
Public.

Description

This is a continuation of http://codereview.chromium.org/5519016/, adds a new GetInstance() method for remaining files with singleton classes under chrome/browser. For types declared and used within the same .cc file, I changed them over to LazyInstance<T>. BUG=65298 TEST=all existing tests should continue to pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68739

Patch Set 1 : . #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -141 lines) Patch
M chrome/browser/accessibility/browser_accessibility_state.h View 1 chunk +3 lines, -0 lines 1 comment Download
M chrome/browser/accessibility/browser_accessibility_state.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_controller_mac.mm View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/audio_handler.h View 1 chunk +1 line, -3 lines 1 comment Download
M chrome/browser/chromeos/audio_handler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/imageburner_ui.h View 3 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/imageburner_ui.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor.h View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 7 chunks +13 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 3 chunks +9 lines, -3 lines 1 comment Download
M chrome/browser/chromeos/login/signed_settings_temp_storage.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/usb_mount_observer.h View 3 chunks +6 lines, -5 lines 1 comment Download
M chrome/browser/chromeos/usb_mount_observer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/volume_bubble.h View 1 chunk +1 line, -3 lines 2 comments Download
M chrome/browser/chromeos/volume_bubble.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/constrained_html_ui.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/html_dialog_ui.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/mediaplayer_ui.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/dom_ui/mediaplayer_ui.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/download/download_util.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_omnibox_api.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_test_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_test_api.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/file_path_watcher/file_path_watcher_inotify.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/gtk/accelerators_gtk.h View 2 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/gtk/accelerators_gtk.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_titlebar.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/gconf_titlebar_listener.h View 1 chunk +3 lines, -0 lines 1 comment Download
M chrome/browser/gtk/gconf_titlebar_listener.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/predictor_api.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_message_filter_gtk.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/service/service_process_control.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/speech_input_dispatcher_host.h View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/speech/speech_input_dispatcher_host.cc View 9 chunks +25 lines, -18 lines 0 comments Download
M chrome/browser/speech/speech_input_manager.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/accelerators_cocoa.h View 2 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/accelerators_cocoa.mm View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/accelerators_cocoa_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/clear_browsing_data_controller.mm View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/keyword_editor_cocoa_controller.mm View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/view_id_util.mm View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/upgrade_detector.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/upgrade_detector.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Satish
10 years ago (2010-12-09 14:30:29 UTC) #1
joth
10 years ago (2010-12-09 15:06:40 UTC) #2 
LGTM

Would be good to tidy up these other header includes whilst there, unless it
causes masses more files to have to be pulled into the patch.

http://codereview.chromium.org/5711001/diff/2001/chrome/browser/accessibility...
File chrome/browser/accessibility/browser_accessibility_state.h (right):

http://codereview.chromium.org/5711001/diff/2001/chrome/browser/accessibility...
chrome/browser/accessibility/browser_accessibility_state.h:10: #include
"base/singleton.h"
remove, fwd declare traits

http://codereview.chromium.org/5711001/diff/2001/chrome/browser/chromeos/audi...
File chrome/browser/chromeos/audio_handler.h (right):

http://codereview.chromium.org/5711001/diff/2001/chrome/browser/chromeos/audi...
chrome/browser/chromeos/audio_handler.h:10: #include "base/singleton.h"
remove, fwd declare traits

http://codereview.chromium.org/5711001/diff/2001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/5711001/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/login_utils.cc:15: #include "base/singleton.h"
remove, fwd declare traits

http://codereview.chromium.org/5711001/diff/2001/chrome/browser/chromeos/usb_...
File chrome/browser/chromeos/usb_mount_observer.h (right):

http://codereview.chromium.org/5711001/diff/2001/chrome/browser/chromeos/usb_...
chrome/browser/chromeos/usb_mount_observer.h:12: #include "base/singleton.h"
remove, fwd declare traits

http://codereview.chromium.org/5711001/diff/2001/chrome/browser/chromeos/volu...
File chrome/browser/chromeos/volume_bubble.h (left):

http://codereview.chromium.org/5711001/diff/2001/chrome/browser/chromeos/volu...
chrome/browser/chromeos/volume_bubble.h:19: }
this style is going to be very hard to stop creeping back into the code

http://codereview.chromium.org/5711001/diff/2001/chrome/browser/chromeos/volu...
File chrome/browser/chromeos/volume_bubble.h (right):

http://codereview.chromium.org/5711001/diff/2001/chrome/browser/chromeos/volu...
chrome/browser/chromeos/volume_bubble.h:9: #include "base/singleton.h"
remove, fwd declare traits

http://codereview.chromium.org/5711001/diff/2001/chrome/browser/gtk/gconf_tit...
File chrome/browser/gtk/gconf_titlebar_listener.h (right):

http://codereview.chromium.org/5711001/diff/2001/chrome/browser/gtk/gconf_tit...
chrome/browser/gtk/gconf_titlebar_listener.h:16: #include "base/singleton.h"
remove, fwd declare traits

Powered by Google App Engine
This is Rietveld 408576698