chrome/browser/ui/cocoa/accelerators_cocoa_unittest.mm - Issue 5711001: Add a new GetInstance() method for remaining files with singleton classes under chrome/browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/accelerators_cocoa_unittest.mm

Issue 5711001: Add a new GetInstance() method for remaining files with singleton classes under chrome/browser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/gtk/gconf_titlebar_listener.h ('K') | « chrome/browser/ui/cocoa/accelerators_cocoa.mm ('k') | chrome/browser/ui/cocoa/clear_browsing_data_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/accelerators_cocoa_unittest.mm

diff --git a/chrome/browser/ui/cocoa/accelerators_cocoa_unittest.mm b/chrome/browser/ui/cocoa/accelerators_cocoa_unittest.mm

index e2b27f00cca26346068b007913bd45dbec23dde6..ef1436de3590e1deabd824db4a3518f4762a2d81 100644

--- a/chrome/browser/ui/cocoa/accelerators_cocoa_unittest.mm

+++ b/chrome/browser/ui/cocoa/accelerators_cocoa_unittest.mm

@@ -12,7 +12,7 @@

#include "testing/gtest_mac.h"

TEST(AcceleratorsCocoaTest, GetAccelerator) {

- AcceleratorsCocoa* keymap = Singleton<AcceleratorsCocoa>::get();

+ AcceleratorsCocoa* keymap = AcceleratorsCocoa::GetInstance();

const menus::AcceleratorCocoa* accelerator =

keymap->GetAcceleratorForCommand(IDC_COPY);

ASSERT_TRUE(accelerator);

@@ -21,7 +21,7 @@ TEST(AcceleratorsCocoaTest, GetAccelerator) {

}

TEST(AcceleratorsCocoaTest, GetNullAccelerator) {

- AcceleratorsCocoa* keymap = Singleton<AcceleratorsCocoa>::get();

+ AcceleratorsCocoa* keymap = AcceleratorsCocoa::GetInstance();

const menus::AcceleratorCocoa* accelerator =

keymap->GetAcceleratorForCommand(314159265);

EXPECT_FALSE(accelerator);