Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 571014: Split out of reverted change http://src.chromium.org/viewvc/chrome?view=rev&r... (Closed)

Created:
10 years, 10 months ago by joth
Modified:
9 years, 7 months ago
Reviewers:
bulach
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Split out of reverted change http://src.chromium.org/viewvc/chrome?view=rev&revision=38207 Commit fixes to code under test, whilst tests themselves are still pending. BUG=http://crbug.com/11246 TEST=see http://codereview.chromium.org/578006 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -13 lines) Patch
M chrome/browser/geolocation/location_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/network_location_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/network_location_request.cc View 3 chunks +20 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
joth
Splitting it yet again.. this is just the code fixes..
10 years, 10 months ago (2010-02-05 15:51:12 UTC) #1
bulach
10 years, 10 months ago (2010-02-05 16:21:23 UTC) #2
On 2010/02/05 15:51:12, jothchrome wrote:
> Splitting it yet again.. this is just the code fixes..

LGTM

Powered by Google App Engine
This is Rietveld 408576698