Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: chrome/browser/chromeos/login/existing_user_controller.cc

Issue 5709001: Place the spinner in the right corner of the controls window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/browser/chromeos/login
Patch Set: Merged with trunk. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/existing_user_controller.cc
diff --git a/chrome/browser/chromeos/login/existing_user_controller.cc b/chrome/browser/chromeos/login/existing_user_controller.cc
index 9718534e801e930ef988fbfb8f3d6144019b9299..307971131429dc7098cc4beafd53a632c0a33be3 100644
--- a/chrome/browser/chromeos/login/existing_user_controller.cc
+++ b/chrome/browser/chromeos/login/existing_user_controller.cc
@@ -214,14 +214,11 @@ void ExistingUserController::LoginNewUser(const std::string& username,
DCHECK(new_user->is_new_user());
if (!new_user->is_new_user())
return;
- NewUserView* new_user_view = new_user->new_user_view();
- new_user_view->SetUsername(username);
if (password.empty())
return;
- new_user_view->SetPassword(password);
- new_user_view->Login();
+ new_user->OnLogin(username, password);
}
void ExistingUserController::SelectNewUser() {
@@ -361,6 +358,14 @@ void ExistingUserController::ActivateWizard(const std::string& screen_name) {
// is doing an animation with our windows.
DCHECK(!delete_scheduled_instance_);
delete_scheduled_instance_ = this;
+
+ // Stop throbbers now to prevent throbbers be visible under the newly created
+ // windows.
+ for (std::vector<UserController*>::iterator iter = controllers_.begin();
whywhat 2010/12/09 16:20:18 Using indices here would be shorter and more reada
altimofeev 2010/12/10 16:37:40 Good point! Done.
+ iter != controllers_.end(); ++iter) {
+ (*iter)->StopThrobber();
+ }
+
delete_timer_.Start(base::TimeDelta::FromSeconds(1), this,
&ExistingUserController::Delete);
}
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/existing_user_view.h » ('j') | chrome/browser/chromeos/login/existing_user_view.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698