Place the spinner in the right corner of the controls window.

chrome/browser/chromeos/login/existing_user_controller.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/existing_user_controller.h"
 
 #include <algorithm>
 #include <functional>
 #include <map>
 
@@ skipping 196 matching lines @@
   background_view_ = background_view;
 }
 
 void ExistingUserController::LoginNewUser(const std::string& username,
                                           const std::string& password) {
   SelectNewUser();
   UserController* new_user = controllers_.back();
   DCHECK(new_user->is_new_user());
   if (!new_user->is_new_user())
     return;
-  NewUserView* new_user_view = new_user->new_user_view();
-  new_user_view->SetUsername(username);
 
   if (password.empty())
     return;
 
-  new_user_view->SetPassword(password);
-  new_user_view->Login();
+  new_user->OnLogin(username, password);
 }
 
 void ExistingUserController::SelectNewUser() {
   SelectUser(controllers_.size() - 1);
 }
 
 void ExistingUserController::SetStatusAreaEnabled(bool enable) {
   if (background_view_) {
     background_view_->SetStatusAreaEnabled(enable);
   }
@@ skipping 119 matching lines @@
   background_window_ = NULL;
 
   controller->Init(screen_name, background_bounds_);
   controller->set_start_url(start_url_);
   controller->Show();
 
   // And schedule us for deletion. We delay for a second as the window manager
   // is doing an animation with our windows.
   DCHECK(!delete_scheduled_instance_);
   delete_scheduled_instance_ = this;
+
+  // Stop throbbers now to prevent throbbers be visible under the newly created
+  // windows.
+  for (std::vector<UserController*>::iterator iter = controllers_.begin();

[whywhat, 2010/12/09 16:20:18]

Using indices here would be shorter and more readabe, imo.

[altimofeev, 2010/12/10 16:37:40]

Good point! Done.

+       iter != controllers_.end(); ++iter) {
+    (*iter)->StopThrobber();
+  }
+
   delete_timer_.Start(base::TimeDelta::FromSeconds(1), this,
                       &ExistingUserController::Delete);
 }
 
 void ExistingUserController::RemoveUser(UserController* source) {
   ClearErrors();
 
   // Owner is not allowed to be removed from the device.
   // It must be enforced at upper levels.
   DCHECK(user_settings_->RequestTrustedOwner(NULL));
@@ skipping 239 matching lines @@
 void ExistingUserController::RecoverEncryptedData(
     const std::string& old_password) {
   login_performer_->RecoverEncryptedData(old_password);
 }
 
 void ExistingUserController::ResyncEncryptedData() {
   login_performer_->ResyncEncryptedData();
 }
 
 }  // namespace chromeos