Have Chrome Frame "support" IE conditional comment tags (of the downlevel-hid...

Have Chrome Frame "support" IE conditional comment tags (of the downlevel-hidden variety) by ignoring them (rather than treating them as comment start/end) when parsing HTML streams.

BUG=65627
TEST=chrome_frame_unittests.exe, also syntax like <!--[if IE]><meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"><![endif]-->  will now activate CF. 

Offtopic: I wonder what happens if I paste HTML into CL comments. Heh.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69177

[amit, 2010-12-13 22:19:56]

Very nice and excellent tests.
LGTM with a few nits.

http://codereview.chromium.org/5708007/diff/1/chrome_frame/html_utils.cc
File chrome_frame/html_utils.cc (right):

http://codereview.chromium.org/5708007/diff/1/chrome_frame/html_utils.cc#newc...
chrome_frame/html_utils.cc:226: bool
HTMLScanner::IsIEConditionalCommentClose(StringRange* html_string,
nit: const StringRange*?

http://codereview.chromium.org/5708007/diff/1/chrome_frame/html_utils.cc#newc...
chrome_frame/html_utils.cc:227: StrPos pos) {
nit: indent

http://codereview.chromium.org/5708007/diff/1/chrome_frame/html_utils.cc#newc...
chrome_frame/html_utils.cc:230: return *(pos-1) == L']';
In the following expression: <!--[if IE 8]>, is white space allowed between the
last > and preceeding ]?

http://codereview.chromium.org/5708007/diff/1/chrome_frame/html_utils.cc#newc...
chrome_frame/html_utils.cc:258: if (StartsWith(tag_name, L"!--[if", true)) {
Is white space allowed between '!--' and '['?

[robertshield, 2010-12-13 22:29:28]

Thanks!

http://codereview.chromium.org/5708007/diff/1/chrome_frame/html_utils.cc
File chrome_frame/html_utils.cc (right):

http://codereview.chromium.org/5708007/diff/1/chrome_frame/html_utils.cc#newc...
chrome_frame/html_utils.cc:226: bool
HTMLScanner::IsIEConditionalCommentClose(StringRange* html_string,
On 2010/12/13 22:19:56, amit wrote:
> nit: const StringRange*?

Done.

http://codereview.chromium.org/5708007/diff/1/chrome_frame/html_utils.cc#newc...
chrome_frame/html_utils.cc:227: StrPos pos) {
On 2010/12/13 22:19:56, amit wrote:
> nit: indent

Done.

http://codereview.chromium.org/5708007/diff/1/chrome_frame/html_utils.cc#newc...
chrome_frame/html_utils.cc:230: return *(pos-1) == L']';
On 2010/12/13 22:19:56, amit wrote:
> In the following expression: <!--[if IE 8]>, is white space allowed between
the
> last > and preceeding ]?
> 

Not according to the spec
http://msdn.microsoft.com/en-us/library/ms537512(VS.85).aspx#syntax

http://codereview.chromium.org/5708007/diff/1/chrome_frame/html_utils.cc#newc...
chrome_frame/html_utils.cc:258: if (StartsWith(tag_name, L"!--[if", true)) {
On 2010/12/13 22:19:56, amit wrote:
> Is white space allowed between '!--' and '['?

Again, not according to the spec.