Have Chrome Frame "support" IE conditional comment tags (of the downlevel-hid...

chrome_frame/test/html_util_unittests.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <atlsecurity.h>
 #include <shellapi.h>
 #include <string>
 #include <vector>
 
@@ skipping 195 matching lines @@
   EXPECT_TRUE(tag_list[0].GetTagAttribute(L"content", &attribute_value));
   EXPECT_TRUE(attribute_value.Equals(L"chrome=1"));
 }
 
 TEST_F(HtmlUtilUnittest, CloseTagInsideHTMLCommentTest) {
   std::wstring test_data(
     L"<!-- comment> <META http-equiv=X-UA-Compatible content='chrome=1'/>-->");
 
   HTMLScanner scanner(test_data.c_str());
 
-  // Grab the meta tag from the document and ensure that we get exactly one.
+  // Ensure that the the meta tag is NOT detected.
   HTMLScanner::StringRangeList tag_list;
   scanner.GetTagsByName(L"meta", &tag_list, L"body");
   ASSERT_TRUE(tag_list.empty());
 }
 
+TEST_F(HtmlUtilUnittest, IEConditionalCommentTest) {
+  std::wstring test_data(
+      L"<!--[if lte IE 8]><META http-equiv=X-UA-Compatible content='chrome=1'/>"
+      L"<![endif]-->");
+
+  HTMLScanner scanner(test_data.c_str());
+
+  // Ensure that the the meta tag IS detected.
+  HTMLScanner::StringRangeList tag_list;
+  scanner.GetTagsByName(L"meta", &tag_list, L"body");
+  ASSERT_EQ(1, tag_list.size());
+}
+
+TEST_F(HtmlUtilUnittest, IEConditionalCommentWithNestedCommentTest) {
+  std::wstring test_data(
+      L"<!--[if IE]><!--<META http-equiv=X-UA-Compatible content='chrome=1'/>"
+      L"--><![endif]-->");
+
+  HTMLScanner scanner(test_data.c_str());
+
+  // Ensure that the the meta tag IS NOT detected.
+  HTMLScanner::StringRangeList tag_list;
+  scanner.GetTagsByName(L"meta", &tag_list, L"body");
+  ASSERT_TRUE(tag_list.empty());
+}
+
+TEST_F(HtmlUtilUnittest, IEConditionalCommentWithMultipleNestedTagsTest) {
+  std::wstring test_data(
+      L"<!--[if lte IE 8]>        <META http-equiv=X-UA-Compatible "
+      L"content='chrome=1'/><foo bar></foo><foo baz/><![endif]-->"
+      L"<boo hoo><boo hah>");
+
+  HTMLScanner scanner(test_data.c_str());
+
+  // Ensure that the the meta tag IS detected.
+  HTMLScanner::StringRangeList meta_tag_list;
+  scanner.GetTagsByName(L"meta", &meta_tag_list, L"body");
+  ASSERT_EQ(1, meta_tag_list.size());
+
+  // Ensure that the foo tags are also detected.
+  HTMLScanner::StringRangeList foo_tag_list;
+  scanner.GetTagsByName(L"foo", &foo_tag_list, L"body");
+  ASSERT_EQ(2, foo_tag_list.size());
+
+  // Ensure that the boo tags are also detected.
+  HTMLScanner::StringRangeList boo_tag_list;
+  scanner.GetTagsByName(L"boo", &boo_tag_list, L"body");
+  ASSERT_EQ(2, boo_tag_list.size());
+}
+
+TEST_F(HtmlUtilUnittest, IEConditionalCommentWithAlternateEndingTest) {
+  std::wstring test_data(
+      L"<!--[if lte IE 8]>        <META http-equiv=X-UA-Compatible "
+      L"content='chrome=1'/><foo bar></foo><foo baz/><![endif]>"
+      L"<boo hoo><!--><boo hah>");
+
+  HTMLScanner scanner(test_data.c_str());
+
+  // Ensure that the the meta tag IS detected.
+  HTMLScanner::StringRangeList meta_tag_list;
+  scanner.GetTagsByName(L"meta", &meta_tag_list, L"body");
+  ASSERT_EQ(1, meta_tag_list.size());
+
+  // Ensure that the foo tags are also detected.
+  HTMLScanner::StringRangeList foo_tag_list;
+  scanner.GetTagsByName(L"foo", &foo_tag_list, L"body");
+  ASSERT_EQ(2, foo_tag_list.size());
+
+  // Ensure that the boo tags are also detected.
+  HTMLScanner::StringRangeList boo_tag_list;
+  scanner.GetTagsByName(L"boo", &boo_tag_list, L"body");
+  ASSERT_EQ(2, boo_tag_list.size());
+}
+
+TEST_F(HtmlUtilUnittest, IEConditionalCommentNonTerminatedTest) {
+  // This test shouldn't detect any tags up until the end of the conditional
+  // comment tag.
+  std::wstring test_data(
+      L"<!--[if lte IE 8>        <META http-equiv=X-UA-Compatible "
+      L"content='chrome=1'/><foo bar></foo><foo baz/><![endif]>"
+      L"<boo hoo><!--><boo hah>");
+
+  HTMLScanner scanner(test_data.c_str());
+
+  // Ensure that the the meta tag IS NOT detected.
+  HTMLScanner::StringRangeList meta_tag_list;
+  scanner.GetTagsByName(L"meta", &meta_tag_list, L"body");
+  ASSERT_TRUE(meta_tag_list.empty());
+
+  // Ensure that the foo tags are NOT detected.
+  HTMLScanner::StringRangeList foo_tag_list;
+  scanner.GetTagsByName(L"foo", &foo_tag_list, L"body");
+  ASSERT_TRUE(foo_tag_list.empty());
+
+  // Ensure that the boo tags are detected.
+  HTMLScanner::StringRangeList boo_tag_list;
+  scanner.GetTagsByName(L"boo", &boo_tag_list, L"body");
+  ASSERT_EQ(2, boo_tag_list.size());
+}
+
 TEST_F(HtmlUtilUnittest, AddChromeFrameToUserAgentValue) {
   struct TestCase {
     std::string input_;
     std::string expected_;
   } test_cases[] = {
     {
       "", ""
     }, {
       "Mozilla/4.7 [en] (WinNT; U)",
       "Mozilla/4.7 [en] (WinNT; U) chromeframe/0.0.0.0"
@@ skipping 138 matching lines @@
     "Content-Length: 42\r\n"
     "X-Frame-Options: SAMEORIGIN\r\n"));
   EXPECT_TRUE(http_utils::HasFrameBustingHeader(
     "X-Frame-Options: deny\r\n"
     "X-Frame-Options: ALLOWall\r\n"
     "Content-Length: 42\r\n"));
   EXPECT_TRUE(http_utils::HasFrameBustingHeader(
     "X-Frame-Options: SAMEORIGIN\r\n"
     "X-Frame-Options: ALLOWall\r\n"));
 }