Fix extension packer command-line code for Mac

chrome/browser/extensions/pack_extension_job.h

Index: chrome/browser/extensions/pack_extension_job.h
diff --git a/chrome/browser/extensions/pack_extension_job.h b/chrome/browser/extensions/pack_extension_job.h
index ecd3d68a91d76ad59f3fa53a87f247bdfffe9fff..fb4699587b577a430aaa1ffcf7e06ff998fd8b97 100644
--- a/chrome/browser/extensions/pack_extension_job.h
+++ b/chrome/browser/extensions/pack_extension_job.h
@@ -33,8 +33,7 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> {
                    const FilePath& root_directory,
                    const FilePath& key_file);
 
-  // Starts the packing thread job. See http://crbug.com/27944 for more details
-  // on why this function is needed.
+  // Starts the packing job.

[Mark Mentovai, 2010/12/13 20:44:46]

fudgey.

[Bons, 2010/12/13 22:08:27]

Done.

   void Start();
 
   // The client should call this when it is destroyed to prevent
@@ -45,12 +44,16 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> {
   static std::wstring StandardSuccessMessage(const FilePath& crx_file,
                                              const FilePath& key_file);
 
+  void set_asynchronous(bool async) { async_ = async; }

[Mark Mentovai, 2010/12/13 20:44:46]

If the member is named async_, this should be set_async.

[Bons, 2010/12/13 22:08:27]

Done.

+
  private:
   friend class base::RefCountedThreadSafe<PackExtensionJob>;
 
   virtual ~PackExtensionJob();
 
-  void RunOnFileThread();
+  // Depending on the value of |async_|, this could be run on either the client

[Mark Mentovai, 2010/12/13 20:44:46]

This still sounds like it’ll run on one thread or another. If async_ is false,
this will just run on whatever thread calls it. Say that?

[Bons, 2010/12/13 22:08:27]

Done.

+  // or file thread.
+  void Run();
   void ReportSuccessOnClientThread();
   void ReportFailureOnClientThread(const std::string& error);
 
@@ -60,6 +63,7 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> {
   FilePath key_file_;
   FilePath crx_file_out_;
   FilePath key_file_out_;
+  bool async_;
 
   DISALLOW_COPY_AND_ASSIGN(PackExtensionJob);
 };