Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: chrome/browser/autofill/autofill_download.h

Issue 5703002: Add some basic success/failure UMA logging for autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_download.h
diff --git a/chrome/browser/autofill/autofill_download.h b/chrome/browser/autofill/autofill_download.h
index 5987c9dcacede6a2c450e781fe5bccb969691c59..650c789e094e5166d70167fe83e713a769ebe929 100644
--- a/chrome/browser/autofill/autofill_download.h
+++ b/chrome/browser/autofill/autofill_download.h
@@ -11,6 +11,7 @@
#include "base/scoped_vector.h"
#include "base/time.h"
+#include "chrome/browser/autofill/autofill_metrics.h"
#include "chrome/browser/autofill/autofill_profile.h"
#include "chrome/browser/autofill/field_types.h"
#include "chrome/browser/autofill/form_structure.h"
@@ -60,7 +61,9 @@ class AutoFillDownloadManager : public URLFetcher::Delegate {
// Starts a query request to AutoFill servers. The observer is called with the
// list of the fields of all requested forms.
// |forms| - array of forms aggregated in this request.
- bool StartQueryRequest(const ScopedVector<FormStructure>& forms);
+ bool StartQueryRequest(
+ const ScopedVector<FormStructure>& forms,
+ autofill_metrics::LogServerQueryMetricFn log_server_query_metric);
// Start upload request if necessary. The probability of request going
// over the wire are GetPositiveUploadRate() if it was matched by
@@ -101,8 +104,9 @@ class AutoFillDownloadManager : public URLFetcher::Delegate {
// |request_data.query| - if true the data is queried and observer notified
// with new data, if available. If false heuristic data is uploaded to our
// servers.
- bool StartRequest(const std::string& form_xml,
- const FormRequestData& request_data);
+ bool StartRequest(
dhollowa 2010/12/10 21:37:38 The previous formatting is better.
Ilya Sherman 2010/12/11 03:35:03 Oops, had already fixed that locally. Done.
+ const std::string& form_xml,
+ const FormRequestData& request_data);
// URLFetcher::Delegate implementation:
virtual void OnURLFetchComplete(const URLFetcher* source,
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_download.cc » ('j') | chrome/browser/autofill/autofill_metrics.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698