Add some basic success/failure UMA logging for autofill.

chrome/browser/autofill/autofill_download.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_H_
 #pragma once
 
 #include <map>
 #include <string>
 
 #include "base/scoped_vector.h"
 #include "base/time.h"
+#include "chrome/browser/autofill/autofill_metrics.h"
 #include "chrome/browser/autofill/autofill_profile.h"
 #include "chrome/browser/autofill/field_types.h"
 #include "chrome/browser/autofill/form_structure.h"
 #include "chrome/common/net/url_fetcher.h"
 
 class Profile;
 
 // Handles getting and updating AutoFill heuristics.
 class AutoFillDownloadManager : public URLFetcher::Delegate {
  public:
@@ skipping 29 matching lines @@
   // |profile| can be NULL in unit-tests only.
   explicit AutoFillDownloadManager(Profile* profile);
   virtual ~AutoFillDownloadManager();
 
   // |observer| - observer to notify on successful completion or error.
   void SetObserver(AutoFillDownloadManager::Observer *observer);
 
   // Starts a query request to AutoFill servers. The observer is called with the
   // list of the fields of all requested forms.
   // |forms| - array of forms aggregated in this request.
-  bool StartQueryRequest(const ScopedVector<FormStructure>& forms);
+  bool StartQueryRequest(
+      const ScopedVector<FormStructure>& forms,
+      autofill_metrics::LogServerQueryMetricFn log_server_query_metric);
 
   // Start upload request if necessary. The probability of request going
   // over the wire are GetPositiveUploadRate() if it was matched by
   // AutoFill, GetNegativeUploadRate() otherwise. Observer will be called
   // even if there was no actual trip over the wire.
   // |form| - form sent in this request.
   // |form_was_matched| - true if form was matched by the AutoFill.
   bool StartUploadRequest(const FormStructure& form, bool form_was_matched);
 
   // Cancels pending request.
@@ skipping 20 matching lines @@
   friend class AutoFillDownloadTestHelper;  // unit-test.
 
   struct FormRequestData;
 
   // Initiates request to AutoFill servers to download/upload heuristics.
   // |form_xml| - form structure XML to upload/download.
   // |request_data| - form signature hash(es) and indicator if it was a query.
   // |request_data.query| - if true the data is queried and observer notified
   //   with new data, if available. If false heuristic data is uploaded to our
   //   servers.
-  bool StartRequest(const std::string& form_xml,
-                    const FormRequestData& request_data);
+  bool StartRequest(

[dhollowa, 2010/12/10 21:37:38]

The previous formatting is better.

[Ilya Sherman, 2010/12/11 03:35:03]

Oops, had already fixed that locally. Done.

+      const std::string& form_xml,
+      const FormRequestData& request_data);
 
   // URLFetcher::Delegate implementation:
   virtual void OnURLFetchComplete(const URLFetcher* source,
                                   const GURL& url,
                                   const URLRequestStatus& status,
                                   int response_code,
                                   const ResponseCookies& cookies,
                                   const std::string& data);
 
   // Profile for preference storage.
@@ skipping 16 matching lines @@
   double positive_upload_rate_;
   double negative_upload_rate_;
 
   // Needed for unit-test.
   int fetcher_id_for_unittest_;
   bool is_testing_;
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_H_