|
|
Fixes bug in instant that resulted in flickery fade. The problem would
happen if instant wouldn't load the current url and you continued
typing. For example, if the search engine doesn't support the instant
API on each key press you would see the page fade out, then snap in.
The fix is to make sure instant stays active until destroyed. That way
if the preview is no longer valid, but instant is still active the
page can remain faded out.
This also adds a couple more tests for better coverage.
BUG= 66720
66539
TEST=see bug
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69201
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+331 lines, -71 lines) |
Patch |
 |
M |
chrome/browser/gtk/browser_window_gtk.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/gtk/browser_window_gtk.cc
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/instant/instant_browsertest.cc
|
View
|
|
8 chunks |
+155 lines, -13 lines |
0 comments
|
Download
|
|
M |
chrome/browser/instant/instant_controller.h
|
View
|
1
|
4 chunks |
+20 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/instant/instant_controller.cc
|
View
|
1
|
9 chunks |
+51 lines, -21 lines |
0 comments
|
Download
|
|
M |
chrome/browser/instant/instant_delegate.h
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/browser.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/browser_window.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/browser_window_cocoa.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/browser_window_cocoa.mm
|
View
|
1
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
|
View
|
1
|
1 chunk |
+5 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_view.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_view.cc
|
View
|
|
1 chunk |
+6 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/contents_container.h
|
View
|
|
3 chunks |
+14 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/contents_container.cc
|
View
|
|
5 chunks |
+61 lines, -15 lines |
0 comments
|
Download
|
|
A |
chrome/test/data/instant/403.html
|
View
|
1
2
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/test/data/instant/403.html.mock-http-headers
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/test/test_browser_window.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
5701008:
Fixes bug in instant that resulted in flickery fade. The problem would (Closed)
