chrome/browser/instant/instant_delegate.h - Issue 5701008: Fixes bug in instant that resulted in flickery fade. The problem would

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/instant/instant_delegate.h

Issue 5701008: Fixes bug in instant that resulted in flickery fade. The problem would (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome

Patch Set: Adds content to 403.html as bots seem to have problem with empty file Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/instant/instant_delegate.h

diff --git a/chrome/browser/instant/instant_delegate.h b/chrome/browser/instant/instant_delegate.h

index 32d94e64494c957c9b6f9ed552536f0445f12f9a..a908981641ac8e4bae1b6b2db678a33cdec5732f 100644

--- a/chrome/browser/instant/instant_delegate.h

+++ b/chrome/browser/instant/instant_delegate.h

@@ -26,7 +26,9 @@ class InstantDelegate {

// Invoked when the instant TabContents should be shown.

virtual void ShowInstant(TabContentsWrapper* preview_contents) = 0;

- // Invoked when the instant TabContents should be hidden.

+ // Invoked when the instant TabContents should be hidden. Instant still may be

+ // active at the time this is invoked. Use |is_active()| to determine if

+ // instant is still active.

virtual void HideInstant() = 0;

// Invoked when the user does something that should result in the preview

« no previous file with comments | « chrome/browser/instant/instant_controller.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »