Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: chrome/browser/ui/views/tab_contents/tab_contents_container.cc

Issue 5700003: Remove undisplayed tabs from the views hierarchy because event delivery doesn't respect z-order. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tab_contents/tab_contents_container.cc
diff --git a/chrome/browser/ui/views/tab_contents/tab_contents_container.cc b/chrome/browser/ui/views/tab_contents/tab_contents_container.cc
index eb5b1adce10e781e88775744be3dd49dd5876f3c..1830fb223b8d7a8f2277d9dbe9b9311e868926c1 100644
--- a/chrome/browser/ui/views/tab_contents/tab_contents_container.cc
+++ b/chrome/browser/ui/views/tab_contents/tab_contents_container.cc
@@ -38,6 +38,9 @@ void TabContentsContainer::ChangeTabContents(TabContents* contents) {
if (tab_contents_) {
#if !defined(TOUCH_UI)
native_container_->DetachContents(tab_contents_);
+#else
+ views::View *v = static_cast<TabContentsViewViews*>(tab_contents_->view());
sky 2010/12/10 18:20:07 nit: View* v.
+ RemoveChildView(v);
sky 2010/12/10 16:37:21 All these ifdefs are making this class unreadable
#endif
tab_contents_->WasHidden();
RemoveObservers();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698