Remove undisplayed tabs from the views hierarchy because event delivery doesn't respect z-order.

chrome/browser/ui/views/tab_contents/tab_contents_container.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/tab_contents/tab_contents_container.h"
 
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/renderer_host/render_widget_host_view.h"
 #include "chrome/browser/tab_contents/interstitial_page.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
@@ skipping 20 matching lines @@
 
 TabContentsContainer::~TabContentsContainer() {
   if (tab_contents_)
     RemoveObservers();
 }
 
 void TabContentsContainer::ChangeTabContents(TabContents* contents) {
   if (tab_contents_) {
 #if !defined(TOUCH_UI)
     native_container_->DetachContents(tab_contents_);
+#else
+    views::View *v = static_cast<TabContentsViewViews*>(tab_contents_->view());

[sky, 2010/12/10 18:20:07]

nit: View* v.

+    RemoveChildView(v);

[sky, 2010/12/10 16:37:21]

All these ifdefs are making this class unreadable and hard to follow. Remove all
the methods in tab_contents_container.cc that are ifdefd, putting the
implementations in tab_contents_container_touch.cc and
tab_contents_container_views.cc (yes, name sucks).

 #endif
     tab_contents_->WasHidden();
     RemoveObservers();
   }
 #if !defined(TOUCH_UI)
   TabContents* old_contents = tab_contents_;
 #endif
   tab_contents_ = contents;
   // When detaching the last tab of the browser ChangeTabContents is invoked
   // with NULL. Don't attempt to do anything in that case.
@@ skipping 121 matching lines @@
 void TabContentsContainer::RenderWidgetHostViewChanged(
     RenderWidgetHostView* old_view, RenderWidgetHostView* new_view) {
   // Carry over the reserved rect, if possible.
   if (old_view && new_view) {
     new_view->set_reserved_contents_rect(old_view->reserved_contents_rect());
   } else {
     if (reserved_area_delegate_)
       reserved_area_delegate_->UpdateReservedContentsRect(this);
   }
 }