base/platform_thread_win.cc - Issue 5693003: Consider PlatformThread::Join() to be blocking IO.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/platform_thread_win.cc

Issue 5693003: Consider PlatformThread::Join() to be blocking IO. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add comments for shutdown. Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/platform_thread_win.cc

diff --git a/base/platform_thread_win.cc b/base/platform_thread_win.cc

index e5afc52e6ff0d51e8cdbe4fdc77a92e9865d0f82..3697604227fa962456ed8fa2fb43a01d94bc3a98 100644

--- a/base/platform_thread_win.cc

+++ b/base/platform_thread_win.cc

@@ -125,6 +125,7 @@ bool PlatformThread::CreateNonJoinable(size_t stack_size, Delegate* delegate) {

// static

void PlatformThread::Join(PlatformThreadHandle thread_handle) {

DCHECK(thread_handle);

+ base::ThreadRestrictions::AssertIOAllowed();

// Wait for the thread to exit. It should already have terminated but make

// sure this assumption is valid.