base/platform_thread_posix.cc - Issue 5693003: Consider PlatformThread::Join() to be blocking IO.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/platform_thread_posix.cc

Issue 5693003: Consider PlatformThread::Join() to be blocking IO. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add comments for shutdown. Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/platform_thread_posix.cc

diff --git a/base/platform_thread_posix.cc b/base/platform_thread_posix.cc

index e442e9c4571b38859597a68cf1ed3a376271b222..274c5045822ea5b843590c14f8eccc9c247494c7 100644

--- a/base/platform_thread_posix.cc

+++ b/base/platform_thread_posix.cc

@@ -219,5 +219,6 @@ bool PlatformThread::CreateNonJoinable(size_t stack_size, Delegate* delegate) {

// static

void PlatformThread::Join(PlatformThreadHandle thread_handle) {

+ base::ThreadRestrictions::AssertIOAllowed();

Evan Martin 2010/12/10 21:43:04 Perhaps stick a comment in here about how this is

pthread_join(thread_handle, NULL);

}

« no previous file with comments | « no previous file | base/platform_thread_win.cc » ('j') | chrome/browser/browser_process_impl.cc » ('J')