Issue 569010: Use the virtual-frame based optimizing compiler for split-compilation...

Issue 569010: Use the virtual-frame based optimizing compiler for split-compilation... (Closed)

Created:
10 years, 10 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Use the virtual-frame based optimizing compiler for split-compilation bailouts. For now the virtual-frame state at entry of a function is hard-coded when using the virtual-frame based compiler as the secondary compiler. Setup frame pointer correctly on function entry on ARM in fast-codegen-arm. Committed: http://code.google.com/p/v8/source/detail?r=3776

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+319 lines, -252 lines)			Patch
M	src/arm/codegen-arm.h	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	src/arm/codegen-arm.cc	View	1	3 chunks	+104 lines, -89 lines	0 comments	Download
M	src/arm/fast-codegen-arm.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/codegen.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/codegen.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/fast-codegen.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/ia32/codegen-ia32.h	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1	2 chunks	+89 lines, -77 lines	0 comments	Download
M	src/x64/codegen-x64.h	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	src/x64/codegen-x64.cc	View	1	2 chunks	+89 lines, -77 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/569010/diff/1/10 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/569010/diff/1/10#newcode179 src/arm/codegen-arm.cc:179: if (strlen(FLAG_stop_at) > 0 && This should probably ...

10 years, 10 months ago (2010-02-03 00:02:12 UTC) #2

Mads Ager (chromium)

10 years, 10 months ago (2010-02-03 07:58:02 UTC) #3

http://codereview.chromium.org/569010/diff/1/10
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/569010/diff/1/10#newcode179
src/arm/codegen-arm.cc:179: if (strlen(FLAG_stop_at) > 0 &&
On 2010/02/03 00:02:12, Kevin Millikin wrote:
> This should probably be lifted outside the if.

Done.

http://codereview.chromium.org/569010/diff/1/8
File src/fast-codegen.cc (right):

http://codereview.chromium.org/569010/diff/1/8#newcode33
src/fast-codegen.cc:33: #include "codegen.h"
On 2010/02/03 00:02:12, Kevin Millikin wrote:
> I'm surprised you need both codegen.h and codegen-inl.h.

I don't need this additional include.  Removed.

Expand Messages | Collapse Messages