Fix bug where icon is not displayed in extension install bubbles

Fix bug where icon is not displayed in extension install bubbles
when installed from store.

BUG=65346
TEST=Install any extension from the web store. Should see icon
in install success bubble.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69060

[Aaron Boodman, 2010-12-13 00:39:06]

This is a quick fix.

I think that ExtensionInstallUI should really be torn apart into ExtensionDialog
(for generic dialogs about an extension, including uninstall),
ExtnsionInstallDialog (for the installation prompt), and
ExtensionInstallSuccessUI (for the various UI we put up on install success).

But I wanted something easy to merge onto the branch, so here it is.

[asargent_no_longer_on_chrome, 2010-12-13 18:05:11]

lgtm

http://codereview.chromium.org/5690004/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_install_ui.cc (right):

http://codereview.chromium.org/5690004/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_install_ui.cc:280: // Load the image
asynchronously. For the response, check OnImageLoaded.
Would it make sense to check here if the icon was already loaded (by a call to
SetIcon), and go directly to OnImageLoaded if it is?

It doesn't look like the current code would follow this path, but I could
imagine changes in the future that might end up doing that now that you've added
the SetIcon method.

[Aaron Boodman, 2010-12-13 19:58:56]

On 2010/12/13 18:05:11, Antony Sargent wrote:
> lgtm
> 
>
http://codereview.chromium.org/5690004/diff/1/chrome/browser/extensions/exten...
> File chrome/browser/extensions/extension_install_ui.cc (right):
> 
>
http://codereview.chromium.org/5690004/diff/1/chrome/browser/extensions/exten...
> chrome/browser/extensions/extension_install_ui.cc:280: // Load the image
> asynchronously. For the response, check OnImageLoaded.
> Would it make sense to check here if the icon was already loaded (by a call to
> SetIcon), and go directly to OnImageLoaded if it is?
> 
> It doesn't look like the current code would follow this path, but I could
> imagine changes in the future that might end up doing that now that you've
added
> the SetIcon method.

I agree, but doing that would mean a bit more chopping up of this file and I'm
trying to make the change as targeted as possible. Hopefully I'll get around to
doing the split I proposed instead.