Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 5690004: Fix bug where icon is not displayed in extension install bubbles (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index 09fd7ead52614e9afd33162827b5407a2254d766..8ed780af228ea5373233f0233366fdfdd2ab77ad 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -282,7 +282,7 @@ void CrxInstaller::OnUnpackSuccess(const FilePath& temp_dir,
return;
}
- if (client_ || extension_->GetFullLaunchURL().is_valid()) {
+ if (client_) {
Extension::DecodeIcon(extension_.get(), Extension::EXTENSION_ICON_LARGE,
&install_icon_);
}
@@ -430,7 +430,7 @@ void CrxInstaller::ReportSuccessFromUIThread() {
// If there is a client, tell the client about installation.
if (client_)
- client_->OnInstallSuccess(extension_.get());
+ client_->OnInstallSuccess(extension_.get(), install_icon_.get());
// Tell the frontend about the installation and hand off ownership of
// extension_ to it.
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_install_ui.h » ('j') | chrome/browser/extensions/extension_install_ui.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698