Add support for ldrd/strd from Kun Zhang (zhangk@codeaurora.org), Code Aurora

We add the support for ldrd and strd to reduce the ldr/str overheads and to reduce the code size. The changes include new code encoding, code generation, disassembler, and simulator. Thanks.

[Erik Corry, 2010-05-04 07:06:13]

LGTM with comments addressed and updated to be relative to bleeding edge.

http://codereview.chromium.org/568029/diff/8001/9005
File src/arm/assembler-arm.cc (right):

http://codereview.chromium.org/568029/diff/8001/9005#newcode1151
src/arm/assembler-arm.cc:1151: addrmod3(cond | B7 | B6 | B4, dst, src);
This instruction is not available on all CPUs.  Please generate two ldr
instructins on CPUs where it is not available.  See the macro definitions in
constants-arm.h.

http://codereview.chromium.org/568029/diff/8001/9005#newcode1156
src/arm/assembler-arm.cc:1156: addrmod3(cond | B7 | B6 | B5 | B4, src, dst);
And here.

http://codereview.chromium.org/568029/diff/8001/9004
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/568029/diff/8001/9004#newcode1893
src/arm/codegen-arm.cc:1893: // load the current count to r0, load the length to
r1
When we are reformatting comments we should take the oportunity to format them
correctly with capital letters and full stops.

http://codereview.chromium.org/568029/diff/8001/9006
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/568029/diff/8001/9006#newcode806
src/arm/simulator-arm.cc:806: int* Simulator::ReadDW(int32_t addr) {
Please use int32_t for things like this where the size is given by the CPU spec.

http://codereview.chromium.org/568029/diff/8001/9006#newcode807
src/arm/simulator-arm.cc:807: int *ptr = reinterpret_cast<int *>(addr);
int *ptr -> int* ptr

http://codereview.chromium.org/568029/diff/8001/9006#newcode813
src/arm/simulator-arm.cc:813: int32_t *ptr = reinterpret_cast<int32_t*>(addr);
Asterisk placement.

http://codereview.chromium.org/568029/diff/8001/9006#newcode1434
src/arm/simulator-arm.cc:1434: // strd
Please check that rd specifies an even-numbered register.

[zhangk, 2010-05-07 05:32:14]

Hi Erik,

I merged the patch with the latest BL, opened a new issue 2019003, and uploaded
the change there.

-Kun

http://codereview.chromium.org/568029/diff/8001/9005
File src/arm/assembler-arm.cc (right):

http://codereview.chromium.org/568029/diff/8001/9005#newcode1151
src/arm/assembler-arm.cc:1151: addrmod3(cond | B7 | B6 | B4, dst, src);
On 2010/05/04 07:06:13, Erik Corry wrote:

Done.

http://codereview.chromium.org/568029/diff/8001/9005#newcode1156
src/arm/assembler-arm.cc:1156: addrmod3(cond | B7 | B6 | B5 | B4, src, dst);
On 2010/05/04 07:06:13, Erik Corry wrote:

Done.

http://codereview.chromium.org/568029/diff/8001/9004
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/568029/diff/8001/9004#newcode1893
src/arm/codegen-arm.cc:1893: // load the current count to r0, load the length to
r1
On 2010/05/04 07:06:13, Erik Corry wrote:

Done.

http://codereview.chromium.org/568029/diff/8001/9006
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/568029/diff/8001/9006#newcode806
src/arm/simulator-arm.cc:806: int* Simulator::ReadDW(int32_t addr) {
On 2010/05/04 07:06:13, Erik Corry wrote:

Done.

http://codereview.chromium.org/568029/diff/8001/9006#newcode807
src/arm/simulator-arm.cc:807: int *ptr = reinterpret_cast<int *>(addr);
On 2010/05/04 07:06:13, Erik Corry wrote:

Done.

http://codereview.chromium.org/568029/diff/8001/9006#newcode813
src/arm/simulator-arm.cc:813: int32_t *ptr = reinterpret_cast<int32_t*>(addr);
On 2010/05/04 07:06:13, Erik Corry wrote:

Done.

http://codereview.chromium.org/568029/diff/8001/9006#newcode1434
src/arm/simulator-arm.cc:1434: // strd
On 2010/05/04 07:06:13, Erik Corry wrote:

Done.