Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 5676004: Cleanup: Remove unneeded browser_thread.h usage. (Closed)

Created:
10 years ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, ncarter (slow), nkostylev+cc_chromium.org, idana, Alpha Left Google, Sergey Ulanov, Raghu Simha, Erik does not do reviews, tim (not reviewing), jam, cbentzel+watch_chromium.org, brettw-cc_chromium.org, Aaron Boodman, dmac, pam+watch_chromium.org, awong, garykac, Paweł Hajdan Jr., darin-cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Remove unneeded browser_thread.h usage. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69037

Patch Set 1 #

Patch Set 2 : fix win build #

Patch Set 3 : fix cros build #

Patch Set 4 : fix deps #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -71 lines) Patch
M chrome/browser/automation/extension_port_container.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/speech_synthesis_library.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/cryptohome_op.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/cryptohome_op.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/mock_url_fetchers.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/online_attempt.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/owner_manager_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/views/domui_menu_widget.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/device_orientation/provider_impl.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/constrained_html_ui_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_favicon_source.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/new_tab_ui_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/shown_sections_handler_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_infobar_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_dom_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_webnavigation_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/favicon_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/geolocation/win7_location_api_unittest_win.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/geolocation/win7_location_provider_unittest_win.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/history/top_sites.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/importer/importer_bridge.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/in_process_webkit/dom_storage_area.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_net_log.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/load_timing_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/load_timing_observer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/passive_log_collector.cc View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/policy/asynchronous_policy_loader.cc View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/policy/asynchronous_policy_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/policy/device_management_service_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/printing/cloud_print/cloud_print_setup_source.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/remoting/remoting_resources_source.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/cross_site_resource_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/x509_user_cert_resource_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/syncer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/history_model_worker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/password_model_associator.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmark_bar_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/html_dialog_view_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/worker_host/message_port_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/reliability/page_load_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/profiles/generate_profile.cc View 1 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
10 years ago (2010-12-10 23:30:02 UTC) #1
Elliot Glaysher
LGTM On Fri, Dec 10, 2010 at 3:30 PM, <thestig@chromium.org> wrote: > Reviewers: Elliot Glaysher, ...
10 years ago (2010-12-10 23:32:09 UTC) #2
Lei Zhang
10 years ago (2010-12-11 00:20:36 UTC) #3
http://codereview.chromium.org/5676004/diff/117001/chrome/tools/profiles/gene...
File chrome/tools/profiles/generate_profile.cc (right):

http://codereview.chromium.org/5676004/diff/117001/chrome/tools/profiles/gene...
chrome/tools/profiles/generate_profile.cc:24: #include
"chrome/browser/browser_thread.h"
This tripped check_deps.py, so I modified chrome/tools/DEPS. Let's not kid
ourselves into believing we only include files from chrome/browser/history, when
chrome/browser/history/top_sites.h used to include
chrome/browser/browser_thread.h.

Powered by Google App Engine
This is Rietveld 408576698