Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Side by Side Diff: chrome/browser/dom_ui/shown_sections_handler_unittest.cc

Issue 5676004: Cleanup: Remove unneeded browser_thread.h usage. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix deps Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/dom_ui/shown_sections_handler.h" 5 #include "chrome/browser/dom_ui/shown_sections_handler.h"
6 6
7 #include "base/scoped_ptr.h" 7 #include "base/scoped_ptr.h"
8 #include "chrome/browser/browser_thread.h"
9 #include "chrome/browser/prefs/pref_value_store.h" 8 #include "chrome/browser/prefs/pref_value_store.h"
10 #include "chrome/common/json_pref_store.h" 9 #include "chrome/common/json_pref_store.h"
11 #include "chrome/common/pref_names.h" 10 #include "chrome/common/pref_names.h"
12 #include "chrome/test/testing_pref_service.h" 11 #include "chrome/test/testing_pref_service.h"
13 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
14 13
15 class ShownSectionsHandlerTest : public testing::Test { 14 class ShownSectionsHandlerTest : public testing::Test {
16 }; 15 };
17 16
18 namespace { 17 namespace {
19 18
20 int MigratePrefValue(PrefService* prefs, int starting_value) { 19 int MigratePrefValue(PrefService* prefs, int starting_value) {
21 prefs->SetInteger(prefs::kNTPShownSections, starting_value); 20 prefs->SetInteger(prefs::kNTPShownSections, starting_value);
22 ShownSectionsHandler::MigrateUserPrefs(prefs, 1, 3); 21 ShownSectionsHandler::MigrateUserPrefs(prefs, 1, 3);
23 return prefs->GetInteger(prefs::kNTPShownSections); 22 return prefs->GetInteger(prefs::kNTPShownSections);
24 } 23 }
25 24
26 } 25 } // namespace
27 26
28 TEST_F(ShownSectionsHandlerTest, MigrateUserPrefs) { 27 TEST_F(ShownSectionsHandlerTest, MigrateUserPrefs) {
29 scoped_ptr<PrefService> pref(new TestingPrefService); 28 scoped_ptr<PrefService> pref(new TestingPrefService);
30 29
31 pref->RegisterIntegerPref(prefs::kNTPShownSections, 0); 30 pref->RegisterIntegerPref(prefs::kNTPShownSections, 0);
32 31
33 EXPECT_EQ(APPS, MigratePrefValue(pref.get(), APPS)); 32 EXPECT_EQ(APPS, MigratePrefValue(pref.get(), APPS));
34 EXPECT_EQ(THUMB, MigratePrefValue(pref.get(), THUMB)); 33 EXPECT_EQ(THUMB, MigratePrefValue(pref.get(), THUMB));
35 EXPECT_EQ(APPS, MigratePrefValue(pref.get(), APPS | THUMB)); 34 EXPECT_EQ(APPS, MigratePrefValue(pref.get(), APPS | THUMB));
36 35
37 // 2 is not currently used, but older state may contain it and we should do 36 // 2 is not currently used, but older state may contain it and we should do
38 // something reasonable. 37 // something reasonable.
39 EXPECT_EQ(THUMB, MigratePrefValue(pref.get(), 3)); 38 EXPECT_EQ(THUMB, MigratePrefValue(pref.get(), 3));
40 39
41 // 0 can't correspond to any section, but we should still do something 40 // 0 can't correspond to any section, but we should still do something
42 // reasonable. 41 // reasonable.
43 EXPECT_EQ(THUMB, MigratePrefValue(pref.get(), 0)); 42 EXPECT_EQ(THUMB, MigratePrefValue(pref.get(), 0));
44 } 43 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698