[Chrome OS] Plumb new error codes from SignedSettings to consumers of the API

chrome/browser/chromeos/login/signed_settings_helper.h

Index: chrome/browser/chromeos/login/signed_settings_helper.h
diff --git a/chrome/browser/chromeos/login/signed_settings_helper.h b/chrome/browser/chromeos/login/signed_settings_helper.h
index cfe99e480a1fd10f23207a3f0963f62d53efbfb7..e1d36287a027f7901ef51fecda72ebf0b644946d 100644
--- a/chrome/browser/chromeos/login/signed_settings_helper.h
+++ b/chrome/browser/chromeos/login/signed_settings_helper.h
@@ -6,7 +6,7 @@
 #define CHROME_BROWSER_CHROMEOS_LOGIN_SIGNED_SETTINGS_HELPER_H_
 #pragma once
 
-#include <string>
+#include "chrome/browser/chromeos/login/signed_settings.h"
 
 namespace chromeos {
 
@@ -20,24 +20,30 @@ class SignedSettingsHelper {
    public:
     // Callback of CheckWhitelistOp. |success| indicates whether the op succeeds
     // or not. |email| is the email that is checked against.
-    virtual void OnCheckWhiteListCompleted(
-        bool success, const std::string& email) {}
+    virtual void OnCheckWhitelistCompleted(
+        SignedSettings::ReturnCode code,
+        bool found,

[Denis Lagno, 2010/12/09 11:54:12]

Do we really need this "bool found"?  ReturnCode cannot contain this info?

[Chris Masone, 2010/12/09 16:33:42]

You're probably right...SUCCESS + 'found == false' could just be NOT_FOUND.

+        const std::string& email) {}
 
     // Callback of WhitelistOp that adds |email| to the whitelist.
     virtual void OnWhitelistCompleted(
-        bool success, const std::string& email) {}
+        SignedSettings::ReturnCode code, const std::string& email) {}
 
     // Callback of WhitelistOp that removes |email| to the whitelist.
     virtual void OnUnwhitelistCompleted(
-        bool success, const std::string& email) {}
+        SignedSettings::ReturnCode code, const std::string& email) {}
 
     // Callback of StorePropertyOp.
     virtual void OnStorePropertyCompleted(
-        bool success, const std::string& name, const std::string& value) {}
+        SignedSettings::ReturnCode code,
+        const std::string& name,
+        const std::string& value) {}
 
     // Callback of RetrievePropertyOp.
     virtual void OnRetrievePropertyCompleted(
-        bool success, const std::string& name, const std::string& value) {}
+        SignedSettings::ReturnCode code,
+        const std::string& name,
+        const std::string& value) {}
   };
 
   // Class factory