[Chrome OS] Plumb new error codes from SignedSettings to consumers of the API

chrome/browser/chromeos/login/signed_settings_helper.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_SIGNED_SETTINGS_HELPER_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_SIGNED_SETTINGS_HELPER_H_
 #pragma once
 
-#include <string>
+#include "chrome/browser/chromeos/login/signed_settings.h"
 
 namespace chromeos {
 
 class SignedSettings;
 
 // Helper to serialize signed settings ops, provide unified callback interface,
 // and handle callbacks destruction before ops completion.
 class SignedSettingsHelper {
  public:
   class Callback {
    public:
     // Callback of CheckWhitelistOp. |success| indicates whether the op succeeds
     // or not. |email| is the email that is checked against.
-    virtual void OnCheckWhiteListCompleted(
-        bool success, const std::string& email) {}
+    virtual void OnCheckWhitelistCompleted(
+        SignedSettings::ReturnCode code,
+        bool found,

[Denis Lagno, 2010/12/09 11:54:12]

Do we really need this "bool found"?  ReturnCode cannot contain this info?

[Chris Masone, 2010/12/09 16:33:42]

You're probably right...SUCCESS + 'found == false' could just be NOT_FOUND.

+        const std::string& email) {}
 
     // Callback of WhitelistOp that adds |email| to the whitelist.
     virtual void OnWhitelistCompleted(
-        bool success, const std::string& email) {}
+        SignedSettings::ReturnCode code, const std::string& email) {}
 
     // Callback of WhitelistOp that removes |email| to the whitelist.
     virtual void OnUnwhitelistCompleted(
-        bool success, const std::string& email) {}
+        SignedSettings::ReturnCode code, const std::string& email) {}
 
     // Callback of StorePropertyOp.
     virtual void OnStorePropertyCompleted(
-        bool success, const std::string& name, const std::string& value) {}
+        SignedSettings::ReturnCode code,
+        const std::string& name,
+        const std::string& value) {}
 
     // Callback of RetrievePropertyOp.
     virtual void OnRetrievePropertyCompleted(
-        bool success, const std::string& name, const std::string& value) {}
+        SignedSettings::ReturnCode code,
+        const std::string& name,
+        const std::string& value) {}
   };
 
   // Class factory
   static SignedSettingsHelper* Get();
 
   // Functions to start signed settings ops.
   virtual void StartCheckWhitelistOp(const std::string& email,
                                      Callback* callback) = 0;
   virtual void StartWhitelistOp(const std::string& email,
                                 bool add_to_whitelist,
@@ skipping 23 matching lines @@
  protected:
   SignedSettingsHelper() : test_delegate_(NULL) {
   }
 
   TestDelegate* test_delegate_;
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_SIGNED_SETTINGS_HELPER_H_