Issue 5670002: Remove the 'test' (gtest) knowledge and instead support the generic run_as sy...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5670002: Remove the 'test' (gtest) knowledge and instead support the generic run_as sy... (Closed)

Created:
10 years ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, bradnelson, bradn

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Remove the 'test' (gtest) knowledge and instead support the generic run_as system. BUG=none TEST=none

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -30 lines)			Patch
M	pylib/gyp/generator/msvs.py	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	pylib/gyp/generator/scons.py	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	pylib/gyp/generator/xcode.py	View	1	5 chunks	+8 lines, -20 lines	0 comments	Download
M	pylib/gyp/input.py	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

TVL

Once this is rolled into trunk, I can land http://codereview.chromium.org/5573006/.

10 years ago (2010-12-08 14:23:32 UTC) #1

LGTM, wow, when did that get in there?