Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: pylib/gyp/generator/msvs.py

Issue 5670002: Remove the 'test' (gtest) knowledge and instead support the generic run_as sy... (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pylib/gyp/generator/scons.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/generator/msvs.py
===================================================================
--- pylib/gyp/generator/msvs.py (revision 861)
+++ pylib/gyp/generator/msvs.py (working copy)
@@ -1174,11 +1174,9 @@
def _AddRunAs(p, spec, user_file):
# Add run_as and test targets.
has_run_as = False
- if spec.get('run_as') or int(spec.get('test', 0)):
+ run_as = spec.get('run_as')
+ if run_as:
has_run_as = True
- run_as = spec.get('run_as', {
- 'action' : ['$(TargetPath)', '--gtest_print_time'],
- })
working_directory = run_as.get('working_directory', '.')
action = run_as.get('action', [])
environment = run_as.get('environment', [])
« no previous file with comments | « no previous file | pylib/gyp/generator/scons.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698